Commit cb15a39
HOTFIX: Migrate Forecasts to UCAR THREDDS (#943)
* BUG: Fix hard-coded radius value for parachute added mass calculation (#889)
* Fix hard-coded radius value for parachute added mass calculation
Calculate radius from cd_s using a typical hemispherical parachute drag
coefficient (1.4) when radius is not explicitly provided. This fixes
drift distance calculations for smaller parachutes like drogues.
Formula: R = sqrt(cd_s / (Cd * π))
Closes #860
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Address code review: improve docstrings and add explicit None defaults
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Add CHANGELOG entry for PR #889
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Update rocket.add_parachute to use radius=None for consistency
Changed the default radius from 1.5 to None in the add_parachute method
to match the Parachute class behavior. This ensures consistent automatic
radius calculation from cd_s across both APIs.
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
Fix hard-coded radius value for parachute added mass calculation
Calculate radius from cd_s using a typical hemispherical parachute drag
coefficient (1.4) when radius is not explicitly provided. This fixes
drift distance calculations for smaller parachutes like drogues.
Formula: R = sqrt(cd_s / (Cd * π))
Closes #860
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Add CHANGELOG entry for PR #889
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
MNT: Extract noise initialization to fix pylint too-many-statements in Parachute.__init__
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* Refactor environment method access in controller test for clarity
* fix pylint
* fix comments
* avoid breaking change with drag_coefficient
* reafactors Parachute.__init__ method
* fix tests
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
* ENH: get changes from BUG: All NOAA NOMADS Dependent Atmosphere Models Broken
Fixes #933
* ENH: Add guidelines for simulation safety, Sphinx documentation, and pytest standards (GitHub Copilot) (#937)
* REL: bump version to 1.12
* ENH: Add explicit timeouts to ThrustCurve API requests and update changelog (#940)
* Initial plan
* ENH: Add explicit timeouts to ThrustCurve API requests
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
* DOC: Add timeout fix PR to changelog
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
* ENH: Restore power_off/on_drag as Function objects; add _input attributes for raw user input and update changelog (#941)
* Initial plan
* ENH: Restore power_off/on_drag as Function, add _input attributes for raw user input
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
* DOC: Add PR #941 compatibility fix to changelog
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
* Update rocketpy/rocket/rocket.py
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: ruff pylint
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: MateusStano <mateusstano@usp.br>
* MNT: Remove unused imports and deprecated functions from mathutils/function.py
* BUG: Readd SourceType enumeration for function source types and clean up imports
* BUG: Fix incorrect Jacobian in `only_radial_burn` branch of `SolidMotor.evaluate_geometry` (#944)
* Initial plan
* BUG: Fix incorrect Jacobian in only_radial_burn branch of evaluate_geometry
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
* ENH: move weathercocking_coeff to PointMassRockt
* MNT: ruff
* MNT: fix cyclic import
* BUG: Add wraparound logic for wind direction in environment plots (#939)
* chore: added personal toolkit files
* update branch name in workflow
* chore: update toolkit files
* Fix: add wraparound logic for wind direction and related tests
* style: fix ruff formatting
* Remove unused import
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* refactor: move repetitive logic into helper method
* fix: update test logic in test_environment
* add changelog entry
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: add numpy import to test_environment.py
* MNT: rename constant for wraparound threshold in _break_direction_wraparound method
* ENH: Adaptive Monte Carlo via Convergence Criteria (#922)
* ENH: added a new function (simulate_convergence)
* DOC: added a cell to show simulate_convergence function usage
* TST: integration test for simulate_convergence
* DOC: updated changelog for this PR
* ENH: ran black to lint intg test file
* new fixes thx to copilot comments
* linted rocketpy/simulation/monte_carlo.py
---------
Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>
* DOC: add latitude range in docs
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: remove unnecessary pylint warning
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: remove unnecessary pylint warning
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* DOC: correctly link to WeatherModelMapping
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* DOCS: checked todo
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* ENH: address copilot comments
* TST: improve tests
* ENH: get changes from BUG: All NOAA NOMADS Dependent Atmosphere Models Broken
Fixes #933
* BUG: Fix hard-coded radius value for parachute added mass calculation (#889)
* Fix hard-coded radius value for parachute added mass calculation
Calculate radius from cd_s using a typical hemispherical parachute drag
coefficient (1.4) when radius is not explicitly provided. This fixes
drift distance calculations for smaller parachutes like drogues.
Formula: R = sqrt(cd_s / (Cd * π))
Closes #860
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Address code review: improve docstrings and add explicit None defaults
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Add CHANGELOG entry for PR #889
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Update rocket.add_parachute to use radius=None for consistency
Changed the default radius from 1.5 to None in the add_parachute method
to match the Parachute class behavior. This ensures consistent automatic
radius calculation from cd_s across both APIs.
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
Fix hard-coded radius value for parachute added mass calculation
Calculate radius from cd_s using a typical hemispherical parachute drag
coefficient (1.4) when radius is not explicitly provided. This fixes
drift distance calculations for smaller parachutes like drogues.
Formula: R = sqrt(cd_s / (Cd * π))
Closes #860
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Add CHANGELOG entry for PR #889
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
MNT: Extract noise initialization to fix pylint too-many-statements in Parachute.__init__
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* Refactor environment method access in controller test for clarity
* fix pylint
* fix comments
* avoid breaking change with drag_coefficient
* reafactors Parachute.__init__ method
* fix tests
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
* ENH: Add guidelines for simulation safety, Sphinx documentation, and pytest standards (GitHub Copilot) (#937)
* REL: bump version to 1.12
* BUG: Add wraparound logic for wind direction in environment plots (#939)
* chore: added personal toolkit files
* update branch name in workflow
* chore: update toolkit files
* Fix: add wraparound logic for wind direction and related tests
* style: fix ruff formatting
* Remove unused import
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* refactor: move repetitive logic into helper method
* fix: update test logic in test_environment
* add changelog entry
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: add numpy import to test_environment.py
* MNT: rename constant for wraparound threshold in _break_direction_wraparound method
* DOC: add latitude range in docs
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: remove unnecessary pylint warning
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* MNT: remove unnecessary pylint warning
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
* ENH: address copilot comments
* TST: improve tests
* DOC: correctly link to WeatherModelMapping
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* DOCS: checked todo
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* ENH: Adaptive Monte Carlo via Convergence Criteria (#922)
* ENH: added a new function (simulate_convergence)
* DOC: added a cell to show simulate_convergence function usage
* TST: integration test for simulate_convergence
* DOC: updated changelog for this PR
* ENH: ran black to lint intg test file
* new fixes thx to copilot comments
* linted rocketpy/simulation/monte_carlo.py
---------
Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>
* DEV: remove unwanted changes from develop
* DEV: Update for hotfix
* TST: add tests
* MNT: remove changes from develop again
* MNT: Refactor longitude and latitude index functions
* MNT: ruff
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
Co-authored-by: Khushal Kottaru <khushal.kottaru@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Mohammed S. Al-Mahrouqi <malmahrouqi3@gatech.edu>
Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>1 parent 876ebcd commit cb15a39
17 files changed
Lines changed: 1427 additions & 434 deletions
File tree
- docs
- user
- environment
- 1-atm-models
- 3-further
- rocketpy
- environment
- plots
- tests
- integration/environment
- unit/environment
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
44 | 50 | | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
48 | 54 | | |
| 55 | + | |
49 | 56 | | |
50 | 57 | | |
51 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
| 29 | + | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
24 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
25 | 41 | | |
26 | 42 | | |
27 | 43 | | |
| |||
71 | 87 | | |
72 | 88 | | |
73 | 89 | | |
74 | | - | |
| 90 | + | |
| 91 | + | |
75 | 92 | | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
84 | 96 | | |
85 | 97 | | |
86 | 98 | | |
87 | 99 | | |
88 | 100 | | |
89 | 101 | | |
90 | | - | |
| 102 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
| 114 | + | |
119 | 115 | | |
120 | | - | |
121 | | - | |
| 116 | + | |
| 117 | + | |
122 | 118 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
130 | 122 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | 123 | | |
145 | 124 | | |
146 | 125 | | |
| |||
248 | 227 | | |
249 | 228 | | |
250 | 229 | | |
251 | | - | |
252 | | - | |
253 | | - | |
| 230 | + | |
| 231 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
65 | 63 | | |
66 | 64 | | |
67 | 65 | | |
68 | 66 | | |
69 | 67 | | |
70 | 68 | | |
71 | | - | |
72 | | - | |
73 | | - | |
| 69 | + | |
| 70 | + | |
74 | 71 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 72 | + | |
| 73 | + | |
80 | 74 | | |
81 | 75 | | |
82 | 76 | | |
83 | 77 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 78 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
32 | | - | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| 30 | + | |
28 | 31 | | |
| 32 | + | |
29 | 33 | | |
| 34 | + | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| 38 | + | |
| 39 | + | |
33 | 40 | | |
34 | | - | |
35 | | - | |
| 41 | + | |
| 42 | + | |
36 | 43 | | |
37 | 44 | | |
38 | 45 | | |
| |||
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
75 | 154 | | |
76 | 155 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
84 | 161 | | |
85 | 162 | | |
86 | 163 | | |
| |||
94 | 171 | | |
95 | 172 | | |
96 | 173 | | |
97 | | - | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments