Skip to content

Fix: connection.rs error and improve error handling#30

Open
nafisatou wants to merge 4 commits into
Rust-Cameroon:mainfrom
nafisatou:main
Open

Fix: connection.rs error and improve error handling#30
nafisatou wants to merge 4 commits into
Rust-Cameroon:mainfrom
nafisatou:main

Conversation

@nafisatou

Copy link
Copy Markdown
Collaborator

What This PR Does

  • Fixes type inference error in connection.rs by adding explicit Result<()> type
  • Replaces manual Err(format!(...)) with anyhow::bail!() for cleaner error handling
  • Removes compiler warnings from unused mut variables
  • Adds doc comments for better code readability

Why
This ensures that the project compiles properly and improves overall code

Comment thread Cargo.toml
name = "async-chat"
version = "0.1.0"
edition = "2024"
edition = "2021"

@bansikah22 bansikah22 Apr 6, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafisatou you should use the 2024 and not go back to 2021

@Nkwenti-Severian-Ndongtsop Nkwenti-Severian-Ndongtsop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafisatou please ensure your PR passes all the checks
I can see you have formatting issues.
Always try to run the commands in this workflows manually before requesting a pull, that is

  • cargo fmt --check
  • cargo clippy -- -D warnings
    You can also check the workflow to know what it checks in your code

@micheal-ndoh

Copy link
Copy Markdown
Collaborator

@nafisatou run the ci-local.sh script to check if your code is well formatted before pushing dr

@Christiantyemele

Christiantyemele commented Apr 8, 2025

Copy link
Copy Markdown
Member

@nafisatou fix the failing pipeline with cargo fmt --all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants