Missing/wrong information for real device if test device is enabled

[billtran1632001]

Description

Enabling test device output make the real device vendor and product name become empty. Git bisect point to 49d9257 being the culprit.

>$ headsetcontrol -o json --test-device 0
{
  "name": "HeadsetControl",
  "version": "3.1.0-7-g2f28ea4",
  "api_version": "1.3",
  "hidapi_version": "0.15.0",
  "device_count": 2,
  "devices": [
    {
      "status": "success",
      "device": "HeadsetControl Test device",
      "vendor": "HeadsetControl",
      "product": "Test device",
      "id_vendor": "0xf00b",
      "id_product": "0xa00c",
      "capabilities": [
        "CAP_SIDETONE", 
        "CAP_BATTERY_STATUS", 
        "CAP_NOTIFICATION_SOUND", 
        "CAP_LIGHTS", 
        "CAP_INACTIVE_TIME", 
        "CAP_CHATMIX_STATUS", 
        "CAP_VOICE_PROMPTS", 
        "CAP_ROTATE_TO_MUTE", 
        "CAP_EQUALIZER_PRESET", 
        "CAP_EQUALIZER", 
        "CAP_PARAMETRIC_EQUALIZER", 
        "CAP_MICROPHONE_MUTE_LED_BRIGHTNESS", 
        "CAP_MICROPHONE_VOLUME", 
        "CAP_VOLUME_LIMITER", 
        "CAP_BT_WHEN_POWERED_ON", 
        "CAP_BT_CALL_VOLUME"
      ],
      "capabilities_str": [
        "sidetone", 
        "battery", 
        "notification sound", 
        "lights", 
        "inactive time", 
        "chatmix", 
        "voice prompts", 
        "rotate to mute", 
        "equalizer preset", 
        "equalizer", 
        "parametric equalizer", 
        "microphone mute led brightness", 
        "microphone volume", 
        "volume limiter", 
        "bluetooth when powered on", 
        "bluetooth call volume"
      ],
      "battery": {
        "status": "BATTERY_UNAVAILABLE",
        "level": -1
      },
      "equalizer": {
        "bands": 10,
        "baseline": 0,
        "step": 0.5,
        "min": -10,
        "max": 10
      },
      "equalizer_presets_count": 2,
      "equalizer_presets": {
        "flat": [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ],
        "random": [ 6.0, -8.0, 1.5, 7.0, -1.0, -7.5, -9.0, 0.0, 9.0, 10.0 ]
      },
      "parametric_equalizer": {
        "bands": 10,
        "gain": {
          "step": 0.5,
          "min": -10,
          "max": 10,
          "base": 20
        },
        "q_factor": {
          "min": 0.2,
          "max": 10
        },
        "frequency": {
          "min": 20,
          "max": 20000
        },
        "filter_types": [
          "lowshelf",
          "lowpass",
          "peaking",
          "highpass",
          "highshelf"
        ]
      },
      "chatmix": 0
    },
    {
      "status": "success",
      "device": "SteelSeries Arctis (7/Pro)",
      "vendor": "",
      "product": "",
      "id_vendor": "0x1038",
      "id_product": "0x12ad",
      "capabilities": [
        "CAP_SIDETONE", 
        "CAP_BATTERY_STATUS", 
        "CAP_LIGHTS", 
        "CAP_INACTIVE_TIME", 
        "CAP_CHATMIX_STATUS"
      ],
      "capabilities_str": [
        "sidetone", 
        "battery", 
        "lights", 
        "inactive time", 
        "chatmix"
      ],
      "battery": {
        "status": "BATTERY_UNAVAILABLE",
        "level": -1
      },
      "chatmix": 0
    }
  ]
}

On which OS does the problem happen?

Linux

[billtran1632001]

These lines seem to be skipped:

HeadsetControl/src/main.c

Lines 247 to 248 in abe3ac8

	hid_get_manufacturer_string(device_handle, device->device_hid_vendorname, sizeof(device->device_hid_vendorname) / sizeof(device->device_hid_vendorname[0]));
	hid_get_product_string(device_handle, device->device_hid_productname, sizeof(device->device_hid_productname) / sizeof(device->device_hid_productname[0]));

Now, I wonder if this also affects reporting two or more devices, and not just because test device is enabled.

[billtran1632001]

Also, just notice that my battery and chatmix are unavailable, too. LOL.

[Sapd]

Hello, can you please test on #443

[billtran1632001]

Everything seem to be in order.

{
  "name": "HeadsetControl",
  "version": "continuous-7-g2d821c6",
  "api_version": "1.4",
  "hidapi_version": "0.15.0",
  "device_count": 2,
  "devices": [
    {
      "status": "success",
      "device": "HeadsetControl Test device",
      "vendor": "HeadsetControl",
      "product": "Test Device",
      "id_vendor": "0xf00b",
      "id_product": "0xa00c",
      "capabilities": [
        "CAP_SIDETONE",
        "CAP_BATTERY_STATUS",
        "CAP_NOTIFICATION_SOUND",
        "CAP_LIGHTS",
        "CAP_INACTIVE_TIME",
        "CAP_CHATMIX_STATUS",
        "CAP_VOICE_PROMPTS",
        "CAP_ROTATE_TO_MUTE",
        "CAP_EQUALIZER_PRESET",
        "CAP_EQUALIZER",
        "CAP_PARAMETRIC_EQUALIZER",
        "CAP_MICROPHONE_MUTE_LED_BRIGHTNESS",
        "CAP_MICROPHONE_VOLUME",
        "CAP_VOLUME_LIMITER",
        "CAP_BT_WHEN_POWERED_ON",
        "CAP_BT_CALL_VOLUME"
      ],
      "capabilities_str": [
        "sidetone",
        "battery",
        "notification sound",
        "lights",
        "inactive time",
        "chatmix",
        "voice prompts",
        "rotate to mute",
        "equalizer preset",
        "equalizer",
        "parametric equalizer",
        "microphone mute led brightness",
        "microphone volume",
        "volume limiter",
        "bluetooth when powered on",
        "bluetooth call volume"
      ],
      "battery": {
        "status": "BATTERY_AVAILABLE",
        "level": 42,
        "voltage_mv": 3650,
        "time_to_empty_min": 302
      },
      "equalizer": {
        "bands": 10,
        "baseline": 0,
        "step": 0.5,
        "min": -12,
        "max": 12
      },
      "equalizer_presets_count": 4,
      "chatmix": 64
    },
    {
      "status": "success",
      "device": "SteelSeries Arctis (7/Pro)",
      "vendor": "SteelSeries ",
      "product": "SteelSeries Arctis 7",
      "id_vendor": "0x1038",
      "id_product": "0x12ad",
      "capabilities": [
        "CAP_SIDETONE",
        "CAP_BATTERY_STATUS",
        "CAP_LIGHTS",
        "CAP_INACTIVE_TIME",
        "CAP_CHATMIX_STATUS"
      ],
      "capabilities_str": [
        "sidetone",
        "battery",
        "lights",
        "inactive time",
        "chatmix"
      ],
      "battery": {
        "status": "BATTERY_AVAILABLE",
        "level": 91,
        "time_to_empty_min": 655
      },
      "chatmix": 64
    }
  ]
}