Refactored SmokeTestUiTest

Author: Wavesonics

app/src/androidTest/kotlin/com/darkrockstudios/app/securecamera/SmokeTestUiTest.kt

@@ -5,21 +5,15 @@ import android.content.res.Resources
 import androidx.annotation.StringRes
 import androidx.compose.ui.semantics.Role
 import androidx.compose.ui.semantics.SemanticsProperties
-import androidx.compose.ui.test.SemanticsMatcher
-import androidx.compose.ui.test.assertIsDisplayed
-import androidx.compose.ui.test.hasContentDescription
-import androidx.compose.ui.test.hasSetTextAction
-import androidx.compose.ui.test.hasTextExactly
+import androidx.compose.ui.test.*
+import androidx.compose.ui.test.junit4.ComposeContentTestRule
 import androidx.compose.ui.test.junit4.createAndroidComposeRule
-import androidx.compose.ui.test.onNodeWithText
-import androidx.compose.ui.test.performClick
-import androidx.compose.ui.test.performTextClearance
-import androidx.compose.ui.test.performTextInput
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.rule.GrantPermissionRule
 import kotlinx.coroutines.test.runTest
 import org.junit.Rule
 import org.junit.Test
+import kotlin.time.Duration
 import kotlin.time.Duration.Companion.seconds
 
 
@@ -50,74 +44,21 @@ class SmokeTestUiTest {
 			onNodeWithText(str(R.string.intro_next)).performClick()
 			onNodeWithText(str(R.string.pin_creation_title)).assertIsDisplayed()
 
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_hint),
-					includeEditableText = false
-				)
-			).performTextInput("3133734")
-
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_confirm_hint),
-					includeEditableText = false
-				)
-			).performTextInput("313373")
-
+			setPinFields("3133734", "313373")
 			onNodeWithText(str(R.string.pin_creation_button)).performClick()
+			waitForText(R.string.pin_creation_error)
 
-			onNodeWithText(str(R.string.pin_creation_error)).assertIsDisplayed()
-
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_hint),
-					includeEditableText = false
-				)
-			).apply {
-				performTextClearance()
-				performTextInput("123456")
-			}
-
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_confirm_hint),
-					includeEditableText = false
-				)
-			).apply {
-				performTextClearance()
-				performTextInput("123456")
-			}
-
+			setPinFields("123456", "123456")
 			onNodeWithText(str(R.string.pin_creation_button)).performClick()
+			waitForText(R.string.pin_creation_error_weak_pin)
 
-			onNodeWithText(str(R.string.pin_creation_error_weak_pin)).assertIsDisplayed()
-
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_hint),
-					includeEditableText = false
-				)
-			).apply {
-				performTextClearance()
-				performTextInput("313373")
-			}
-
-			onNode(
-				hasSetTextAction() and hasTextExactly(
-					str(R.string.pin_creation_confirm_hint),
-					includeEditableText = false
-				)
-			).apply {
-				performTextClearance()
-				performTextInput("313373")
-			}
-
+			setPinFields("313373", "313373")
 			onNodeWithText(str(R.string.pin_creation_button)).performClick()
 
-			onNodeWithText(str(R.string.pin_creating_vault)).assertIsDisplayed()
+			waitForText(R.string.pin_creating_vault)
 
 			composeTestRule.waitUntil(
-				timeoutMillis = 10.seconds.inWholeMilliseconds
+				timeoutMillis = 30.seconds.inWholeMilliseconds
 			) {
 				composeTestRule
 					.onAllNodes(hasRole(Role.Button) and hasContentDescription(str(R.string.camera_shutter_button_desc)))
@@ -130,13 +71,57 @@ class SmokeTestUiTest {
 		}
 	}
 
+	private fun ComposeContentTestRule.setPinFields(primary: String, confirm: String) {
+		setTextField(
+			placeholder = R.string.pin_creation_hint,
+			value = primary,
+		)
+
+		setTextField(
+			placeholder = R.string.pin_creation_confirm_hint,
+			value = confirm,
+		)
+	}
+
 	fun hasRole(role: Role): SemanticsMatcher =
 		SemanticsMatcher.expectValue(SemanticsProperties.Role, role)
 
 	private fun str(@StringRes id: Int): String = r.getString(id)
 	private val r: Resources
 		get() {
-			val application = ApplicationProvider.getApplicationContext<Application?>()
+			val application = ApplicationProvider.getApplicationContext<Application>()
 			return application.resources
 		}
+
+	private fun ComposeContentTestRule.waitForText(@StringRes text: Int, timeout: Duration = 10.seconds) {
+		waitForText(str(text), timeout)
+	}
+
+	fun ComposeContentTestRule.waitForText(
+		text: String,
+		timeout: Duration = 10.seconds,
+		useUnmergedTree: Boolean = true,
+		substring: Boolean = true
+	) {
+		waitUntil(timeout.inWholeMilliseconds) {
+			onAllNodes(
+				hasText(text, substring = substring),
+				useUnmergedTree = useUnmergedTree
+			).fetchSemanticsNodes().isNotEmpty()
+		}
+		onNodeWithText(text, substring = substring)
+			.assertIsDisplayed()
+	}
+
+	private fun ComposeContentTestRule.setTextField(value: String, placeholder: Int) {
+		onNode(
+			hasSetTextAction() and hasTextExactly(
+				str(placeholder),
+				includeEditableText = false
+			)
+		).apply {
+			performTextClearance()
+			performTextInput(value)
+		}
+	}
 }