Skip to content

chore_e2e_overnight_strategy_radix_select_timing: Stabilize the overnight Strategy toggle E2E (Radix Select + RHF timing) #488

@SoundMindsAI

Description

@SoundMindsAI

Problem

The Story 3.2 E2E spec for the overnight Strategy toggle was written then deleted because, in chromium against pnpm dev, clicking the depth Radix <Select> updates the visible trigger but the dependent conditional render of the strategy toggle never fires before toBeVisible times out (Radix onValueChange → react-hook-form setValueform.watch() settle across several microtasks/ticks). The toggle itself is fully shipped and covered at every other layer (6 vitest + 10 integration + contract + 2 chain-panel cases) — so an E2E here is duplicative.

What this delivers

A reusable pickRadixSelectAndWaitForDependent helper (dispatch → pick → poll trigger text → force two animation frames) and the revived overnight-strategy.spec.ts rebuilt on it. Only worth doing if another spec actually needs the helper.

Status

  • Stage: IDEA
  • Priority: Backlog (demoted from P2 on 2026-06-05 — duplicative coverage; see idea.md)

Definition of done

  • Shared Radix-Select wait helper added under ui/tests/e2e/helpers/.
  • overnight-strategy.spec.ts revived, asserts AC-4 (toggle hidden/visible/hide-on-revert) + AC-5 (submit + read-back), real backend, no page.route().

Artifacts

How to execute

Run /idea-preflight, then /pipeline docs/00_overview/planned_features/02_mvp2/chore_e2e_overnight_strategy_radix_select_timing --auto. Low urgency — only pull forward if the wait helper is needed elsewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    mvp2MVP2 backlog itemneeds-preflightIdea-stage; run /idea-preflight before /pipelinepriority/backlogBacklog — captured for record, not plannedtype/choreChore — non-feature cleanup

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions