fix(logging): partition raw rewards for correct samples#1996
Open
Jiang020609 wants to merge 1 commit into
Open
fix(logging): partition raw rewards for correct samples#1996Jiang020609 wants to merge 1 commit into
Jiang020609 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1784. Summary: partition raw_reward alongside total_lengths in process_rollout_data so --log-correct-samples sees per-rank lists; preserve global_raw_reward for --log-passrate and skip it from generic rollout metrics; add CPU tests for partitioning and passrate preservation. Tests: .venv\Scripts\python.exe -m pytest tests\test_process_rollout_data.py; .venv\Scripts\python.exe -m ruff check slime\utils\data.py slime\backends\megatron_utils\data.py tests\test_process_rollout_data.py; .venv\Scripts\pre-commit.exe run --files slime\utils\data.py slime\backends\megatron_utils\data.py tests\test_process_rollout_data.py.