diff --git a/Core/GameEngine/Include/GameNetwork/GameInfo.h b/Core/GameEngine/Include/GameNetwork/GameInfo.h index d17a3bd3c12..f4904be9ed3 100644 --- a/Core/GameEngine/Include/GameNetwork/GameInfo.h +++ b/Core/GameEngine/Include/GameNetwork/GameInfo.h @@ -100,7 +100,7 @@ class GameSlot void setNATBehavior( FirewallHelperClass::FirewallBehaviorType NATBehavior) { m_NATBehavior = NATBehavior; } FirewallHelperClass::FirewallBehaviorType getNATBehavior() const { return m_NATBehavior; } - void saveOffOriginalInfo(); + Bool saveOffOriginalInfo(); Int getOriginalPlayerTemplate() const { return m_origPlayerTemplate; } Int getOriginalColor() const { return m_origColor; } Int getOriginalStartPos() const { return m_origStartPos; } @@ -130,6 +130,7 @@ class GameSlot Bool m_isAccepted; Bool m_hasMap; Bool m_isMuted; + Bool m_saveOffOriginalInfo; Int m_color; ///< color, or -1 for random Int m_startPos; ///< start position, or -1 for random Int m_playerTemplate; ///< PlayerTemplate diff --git a/Core/GameEngine/Source/GameNetwork/GameInfo.cpp b/Core/GameEngine/Source/GameNetwork/GameInfo.cpp index 475f51a8683..c24b0f7a734 100644 --- a/Core/GameEngine/Source/GameNetwork/GameInfo.cpp +++ b/Core/GameEngine/Source/GameNetwork/GameInfo.cpp @@ -70,20 +70,29 @@ void GameSlot::reset() m_disconnected = FALSE; m_port = 0; m_isMuted = FALSE; + m_saveOffOriginalInfo = TRUE; m_origPlayerTemplate = -1; m_origStartPos = -1; m_origColor = -1; } -void GameSlot::saveOffOriginalInfo() +Bool GameSlot::saveOffOriginalInfo() { - DEBUG_LOG(("GameSlot::saveOffOriginalInfo() - orig was color=%d, pos=%d, house=%d", - m_origColor, m_origStartPos, m_origPlayerTemplate)); - m_origPlayerTemplate = m_playerTemplate; - m_origStartPos = m_startPos; - m_origColor = m_color; - DEBUG_LOG(("GameSlot::saveOffOriginalInfo() - color=%d, pos=%d, house=%d", - m_color, m_startPos, m_playerTemplate)); + if (m_saveOffOriginalInfo) + { + DEBUG_LOG(("GameSlot::saveOffOriginalInfo() - orig was color=%d, pos=%d, house=%d", + m_origColor, m_origStartPos, m_origPlayerTemplate)); + m_origPlayerTemplate = m_playerTemplate; + m_origStartPos = m_startPos; + m_origColor = m_color; + DEBUG_LOG(("GameSlot::saveOffOriginalInfo() - color=%d, pos=%d, house=%d", + m_color, m_startPos, m_playerTemplate)); + + m_saveOffOriginalInfo = FALSE; + return TRUE; + } + + return FALSE; } static Int getSlotIndex(const GameSlot *slot) diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h index 160d1dbd4cf..aef22d49ffb 100644 --- a/GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h +++ b/GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h @@ -79,6 +79,8 @@ enum GameMode CPP_11(: Int) GAME_NONE }; +const char* gameModeToString(GameMode mode); + enum { CRC_CACHED, diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp index 1d671f180f5..b150503d13e 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp @@ -213,6 +213,30 @@ void setFPMode() _controlfp(newVal, _MCW_PC | _MCW_RC); } +//------------------------------------------------------------------------------------------------- +const char* gameModeToString(GameMode mode) +{ + switch (mode) + { + case GAME_SINGLE_PLAYER: + return "GAME_SINGLE_PLAYER"; + case GAME_LAN: + return "GAME_LAN"; + case GAME_SKIRMISH: + return "GAME_SKIRMISH"; + case GAME_REPLAY: + return "GAME_REPLAY"; + case GAME_SHELL: + return "GAME_SHELL"; + case GAME_INTERNET: + return "GAME_INTERNET"; + case GAME_NONE: + return "GAME_NONE"; + default: + return "GAME_UNKNOWN"; + } +} + // ------------------------------------------------------------------------------------------------ /** GameLogic class constructor */ // ------------------------------------------------------------------------------------------------ @@ -1241,7 +1265,16 @@ void GameLogic::startNewGame( Bool loadingSaveGame ) { GameSlot *slot = TheGameInfo->getSlot(i); if (!loadingSaveGame) { - slot->saveOffOriginalInfo(); + if (!slot->saveOffOriginalInfo()) + { + DEBUG_ASSERTCRASH(m_gameMode == GAME_SKIRMISH, ("Expected GAME_SKIRMISH but got %s", gameModeToString(m_gameMode))); + + // TheSuperHackers @fix Caball009 19/03/2026 Random color, position and faction are based on the logical seed. For improved determinism, + // restarted games now set the original values so that the games start with the exact same logical seed values as the first time. + slot->setColor(slot->getOriginalColor()); + slot->setStartPos(slot->getOriginalStartPos()); + slot->setPlayerTemplate(slot->getOriginalPlayerTemplate()); + } } if (slot->isAI()) {