NetworkAnimator memory leak on clients

[ffejlersen]

Description

NetworkAnimator has memory leaks on clients, regarding RpcTarget.

Reproduce Steps

1. Open NGO_Setup scene
2. Open Multiplayer Play Mode and add an additional client
3. Play and set:
   • Virtual Player: Host
   • Unity Editor: Client
4. Stop play mode
5. Force Foo script to recompile

Actual Outcome

A memory leak was detected after ending play mode and recompiling scripts. The memory leaks are only visible on the client player.

Expected Outcome

No memory leaks

Unity Project and Stack Trace

UnityProject.zip

0x0000028369112163 (Mono JIT Code) Unity.Collections.Memory/Unmanaged/Array:Resize (void*,long,long,Unity.Collections.AllocatorManager/AllocatorHandle,long,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/Memory.cs:79)
0x0000028369111d53 (Mono JIT Code) Unity.Collections.Memory/Unmanaged:Allocate (long,int,Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/Memory.cs:20)
0x0000028369111303 (Mono JIT Code) Unity.Collections.AllocatorManager:TryLegacy (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:1097)
0x0000028369110c63 (Mono JIT Code) Unity.Collections.AllocatorManager:Try (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:1129)
0x0000028369110a53 (Mono JIT Code) Unity.Collections.AllocatorManager/AllocatorHandle:Try (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:613)
0x0000028369110343 (Mono JIT Code) Unity.Collections.AllocatorManager:AllocateBlock<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int,int,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:105)
0x0000028322e4ff23 (Mono JIT Code) Unity.Collections.AllocatorManager:Allocate<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int,int,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:126)
0x000002836959dadb (Mono JIT Code) Unity.Collections.AllocatorManager:Allocate<Unity.Collections.AllocatorManager/AllocatorHandle, Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>> (Unity.Collections.AllocatorManager/AllocatorHandle&,Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:131)
0x000002836959d7cb (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:Create<Unity.Collections.AllocatorManager/AllocatorHandle> (int,Unity.Collections.AllocatorManager/AllocatorHandle&,Unity.Collections.NativeArrayOptions) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:191)
0x000002836959ccd3 (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:Initialize<Unity.Collections.AllocatorManager/AllocatorHandle> (int,Unity.Collections.AllocatorManager/AllocatorHandle&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:132)
0x000002836959c70b (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:.ctor (int,Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:111)
0x000002836959b8db (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:.ctor (Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:98)
0x000002836959b60b (Mono JIT Code) Unity.Netcode.ProxyRpcTargetGroup:.ctor (Unity.Netcode.NetworkManager) (at ./Library/PackageCache/com.unity.netcode.gameobjects@f34cb3e9a59a/Runtime/Messaging/RpcTargets/ProxyRpcTargetGroup.cs:46)
0x00000283fdc8d5ab (Mono JIT Code) Unity.Netcode.RpcTarget:Group<T_REF> (T_REF,Unity.Netcode.RpcTargetUse) (at ./Library/PackageCache/com.unity.netcode.gameobjects@f34cb3e9a59a/Runtime/Messaging/RpcTargets/RpcTarget.cs:440)
0x00000283fdc8cbf3 (Mono JIT Code) Unity.Netcode.Components.NetworkAnimator:OnNetworkSpawn () (at ./Library/PackageCache/com.unity.netcode.gameobjects@f34cb3e9a59a/Runtime/Components/NetworkAnimator.cs:934)
0x00000283fdc87d5a (Mono JIT Code) Unity.Netcode.NetworkBehaviour:NetworkSpawn () (at ./Library/PackageCache/com.unity.netcode.gameobject

0x0000028369112163 (Mono JIT Code) Unity.Collections.Memory/Unmanaged/Array:Resize (void*,long,long,Unity.Collections.AllocatorManager/AllocatorHandle,long,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/Memory.cs:79)
0x0000028369111d53 (Mono JIT Code) Unity.Collections.Memory/Unmanaged:Allocate (long,int,Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/Memory.cs:20)
0x0000028369111303 (Mono JIT Code) Unity.Collections.AllocatorManager:TryLegacy (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:1097)
0x0000028369110c63 (Mono JIT Code) Unity.Collections.AllocatorManager:Try (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:1129)
0x0000028369110a53 (Mono JIT Code) Unity.Collections.AllocatorManager/AllocatorHandle:Try (Unity.Collections.AllocatorManager/Block&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:613)
0x0000028369110343 (Mono JIT Code) Unity.Collections.AllocatorManager:AllocateBlock<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int,int,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:105)
0x0000028322e4ff23 (Mono JIT Code) Unity.Collections.AllocatorManager:Allocate<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int,int,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/AllocatorManager.cs:126)
0x000002836959ea73 (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:ResizeExact<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:354)
0x000002836959e5e3 (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:SetCapacity<Unity.Collections.AllocatorManager/AllocatorHandle> (Unity.Collections.AllocatorManager/AllocatorHandle&,int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:389)
0x000002836959e2f3 (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:SetCapacity (int) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:398)
0x000002836959e05b (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:.ctor (int,Unity.Collections.AllocatorManager/AllocatorHandle,Unity.Collections.NativeArrayOptions) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:179)
0x000002836959d8b3 (Mono JIT Code) Unity.Collections.LowLevel.Unsafe.UnsafeList`1<ulong>:Create<Unity.Collections.AllocatorManager/AllocatorHandle> (int,Unity.Collections.AllocatorManager/AllocatorHandle&,Unity.Collections.NativeArrayOptions) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/UnsafeList.cs:192)
0x000002836959ccd3 (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:Initialize<Unity.Collections.AllocatorManager/AllocatorHandle> (int,Unity.Collections.AllocatorManager/AllocatorHandle&) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:132)
0x000002836959c70b (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:.ctor (int,Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:111)
0x000002836959b8db (Mono JIT Code) Unity.Collections.NativeList`1<ulong>:.ctor (Unity.Collections.AllocatorManager/AllocatorHandle) (at ./Library/PackageCache/com.unity.collections@56bff8827a7e/Unity.Collections/NativeList.cs:98)
0x000002836959b60b (Mono JIT Code) Unity.Netcode.ProxyRpcTargetGroup:.ctor (Unity.Netcode

Environment

• OS: Windows 11
• Unity Version: 6000.0.58f2
• Netcode Version: 2.8.0
• Netcode Topology: Client-Server

[michalChrobot]

Hey, thanks for reporting this, I will take a look

[michalChrobot]

I managed to reproduce the issue so thanks a lot for reporting this!

I'm working on resolution in #3866