Merge pull request #1142 from WordPress/make-markdown-file-check-case-insensitive

Make markdown file check case insensitive

Co-authored-by: ernilambar <nilambar@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>

Author: 4 people

includes/Checker/Checks/Plugin_Repo/File_Type_Check.php

@@ -577,17 +577,18 @@ protected function check_github_directory( Check_Result $result, array $files )
 	 * @param array        $files  List of file paths.
 	 */
 	protected function check_unexpected_markdown_files( Check_Result $result, array $files ) {
-		$plugin_path           = $result->plugin()->path();
-		$allowed_root_md_files = array( 'README.md', 'readme.txt', 'LICENSE', 'LICENSE.md', 'CHANGELOG.md', 'CONTRIBUTING.md', 'SECURITY.md' );
-		$root_md_files         = array();
+		$plugin_path                 = $result->plugin()->path();
+		$allowed_root_md_files       = array( 'README.md', 'readme.txt', 'LICENSE', 'LICENSE.md', 'CHANGELOG.md', 'CONTRIBUTING.md', 'SECURITY.md' );
+		$allowed_root_md_files_lower = array_map( 'strtolower', $allowed_root_md_files );
+		$root_md_files               = array();
 
 		foreach ( $files as $file ) {
 			$relative_path = str_replace( $plugin_path, '', $file );
 			$relative_path = ltrim( $relative_path, '/' );
 			$basename      = basename( $file );
 
 			if ( substr_count( $relative_path, '/' ) === 0 && pathinfo( $file, PATHINFO_EXTENSION ) === 'md' ) {
-				if ( ! in_array( $basename, $allowed_root_md_files, true ) ) {
+				if ( ! in_array( strtolower( $basename ), $allowed_root_md_files_lower, true ) ) {
 					$root_md_files[] = $file;
 				}
 			}

tests/phpunit/testdata/plugins/test-plugin-ai-instructions-errors/Readme.md

@@ -0,0 +1,3 @@
+# Test Plugin
+
+This plugin is for testing purposes.