Please do not use cv qualifiers (const or volatile) in typedefs

[jason-sachs]

from https://github.com/X2Cscope/X2Cscope_library_make/blob/master/interface/X2Cscope.h

typedef const struct compilationDate_type{
	uint8_t date[11];
	uint8_t time[8];
}compilationDate_t;

Could you remove the const? It is up to the application to declare something as const or not.

[jason-sachs]

as a side note, is the pass-by-value of compilationDate_t intentional? (rather than a const compilationDate_t * to pass-by-pointer)

void X2Cscope_Initialise(void* scopeArray, uint16_t scopeSize, uint16_t appVersion, compilationDate_t compilationDate);

This requires the compiler to copy the compilationDate_t data when the function is called. It also looks buggy for other reasons; I've filed #9.

[MarkWendler]

Typedef const is a valid point. This can be improved. The intention here was to create the function parameter const, though can be done separately in the function parameter.

Will be fixed.