ci: GitHub Actions workflow security cleanup#127
Open
emptyhammond wants to merge 3 commits into
Open
Conversation
Set persist-credentials: false on every actions/checkout step so the default GITHUB_TOKEN is not left in the local git config after checkout.
Add top-level permissions: {} to each workflow and grant each job only
the GITHUB_TOKEN scopes it actually needs.
Pin each action reference to a commit SHA with the tag preserved as a comment, so an upstream tag move can't silently change what runs in CI.
owenpearson
approved these changes
May 26, 2026
Member
|
oof, CI is broken on this repo because https://github.com/ably/specification/raw/main/textile/features.textile moved to https://github.com/ably/specification/raw/main/specifications/features.md. This repo tries to parse that document so it will take some work to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into three commits, one per finding type:
No behavioural changes intended — the workflows run the same checks against the same inputs.