Extract shared _get_time_offset method to base class

Author: tukiains

src/processing/instrument_process.py

@@ -124,6 +124,19 @@ def download_instrument(
             time_offset=time_offset,
         )
 
+    def _get_time_offset(
+        self, date: datetime.date | None = None
+    ) -> datetime.timedelta | None:
+        try:
+            calibration = self.processor.client.calibration(
+                self.params.instrument.pid, date or self.params.date
+            )
+            if "time_offset" in calibration["data"]:
+                return datetime.timedelta(minutes=calibration["data"]["time_offset"])
+        except CloudnetAPIError:
+            pass
+        return None
+
 
 class ProcessRadar(ProcessInstrument):
     def process_rpg_fmcw_94(self) -> None:
@@ -232,18 +245,7 @@ def _add_calibration(
 
 class ProcessDopplerLidarWind(ProcessInstrument):
     def process_halo_doppler_lidar(self) -> None:
-        try:
-            calibration = self.processor.client.calibration(
-                self.params.instrument.pid, self.params.date
-            )
-            time_offset = (
-                datetime.timedelta(minutes=calibration["data"]["time_offset"])
-                if "time_offset" in calibration["data"]
-                else None
-            )
-        except CloudnetAPIError:
-            time_offset = None
-
+        time_offset = self._get_time_offset()
         full_paths, self.uuid.raw = self.download_instrument(
             include_pattern=r".*\.hpl",
             exclude_pattern=r"Stare.*",
@@ -352,17 +354,7 @@ def _calibration_options(self) -> doppy.product.WindOptions | None:
 
 class ProcessDopplerLidar(ProcessInstrument):
     def process_halo_doppler_lidar(self) -> None:
-        try:
-            calibration = self.processor.client.calibration(
-                self.params.instrument.pid, self.params.date
-            )
-            time_offset = (
-                datetime.timedelta(minutes=calibration["data"]["time_offset"])
-                if calibration is not None and "time_offset" in calibration["data"]
-                else None
-            )
-        except CloudnetAPIError:
-            time_offset = None
+        time_offset = self._get_time_offset()
         # Co files either have "co" tag or no tags at all.
         full_paths_co, raw_uuids_co = self.download_instrument(
             filename_prefix="Stare",
@@ -537,17 +529,7 @@ def process_cl31(self) -> None:
         self._call_ceilo2nc("cl31")
 
     def process_cl51(self) -> None:
-        try:
-            calibration = self.processor.client.calibration(
-                self.params.instrument.pid, self.params.date
-            )
-            time_offset = (
-                datetime.timedelta(minutes=calibration["data"]["time_offset"])
-                if "time_offset" in calibration["data"]
-                else None
-            )
-        except CloudnetAPIError:
-            time_offset = None
+        time_offset = self._get_time_offset()
         full_paths, self.uuid.raw = self.download_instrument(time_offset=time_offset)
         full_paths.sort()
         _concatenate_text_files(full_paths, self.daily_path)
@@ -560,13 +542,13 @@ def process_cl51(self) -> None:
         self._call_ceilo2nc("cl51")
 
     def process_cl61d(self) -> None:
-        current_offset = self._get_cl61d_time_offset(self.params.date)
+        current_offset = self._get_time_offset(self.params.date)
         full_paths, raw_uuids = self.download_instrument(
             exclude_pattern="clu-generated"
         )
         _apply_cl61d_time_offset(full_paths, current_offset)
         previous_date = self.params.date - datetime.timedelta(days=1)
-        previous_offset = self._get_cl61d_time_offset(previous_date)
+        previous_offset = self._get_time_offset(previous_date)
         n_hours_previous = _cl61d_boundary_hours(
             current_offset, previous_offset, direction="previous"
         )
@@ -582,7 +564,7 @@ def process_cl61d(self) -> None:
             full_paths.extend(paths_previous)
             raw_uuids.extend(uuids_previous)
         next_date = self.params.date + datetime.timedelta(days=1)
-        next_offset = self._get_cl61d_time_offset(next_date)
+        next_offset = self._get_time_offset(next_date)
         n_hours_next = _cl61d_boundary_hours(
             current_offset, next_offset, direction="next"
         )
@@ -618,17 +600,6 @@ def process_cl61d(self) -> None:
         self._call_ceilo2nc("cl61d")
         self.uuid.raw = _get_valid_uuids(raw_uuids, full_paths, valid_full_paths)
 
-    def _get_cl61d_time_offset(self, date: datetime.date) -> datetime.timedelta | None:
-        try:
-            calibration = self.processor.client.calibration(
-                self.params.instrument.pid, date
-            )
-            if "time_offset" in calibration["data"]:
-                return datetime.timedelta(minutes=calibration["data"]["time_offset"])
-        except CloudnetAPIError:
-            pass
-        return None
-
     def process_da10(self) -> None:
         full_paths, raw_uuids = self.download_instrument()
         valid_full_paths = concat_wrapper.concat_netcdf_files(
@@ -928,14 +899,8 @@ def process_weather_station(self) -> None:
         )
         if self.params.site.id not in supported_sites:
             raise NotImplementedError("Weather station not implemented for this site")
-        try:
-            calibration = self.processor.client.calibration(
-                self.params.instrument.pid, self.params.date
-            )
-        except CloudnetAPIError:
-            calibration = None
-        if calibration and calibration.get("data", {}).get("time_offset"):
-            time_offset = datetime.timedelta(minutes=calibration["data"]["time_offset"])
+        time_offset = self._get_time_offset()
+        if time_offset is not None:
             full_paths, self.uuid.raw = self.download_instrument(
                 time_offset=time_offset
             )