Skip to content

feat(server): allow host-owned logging setup#227

Merged
abhinav-galileo merged 2 commits into
mainfrom
feature/galileo-host-observability
May 22, 2026
Merged

feat(server): allow host-owned logging setup#227
abhinav-galileo merged 2 commits into
mainfrom
feature/galileo-host-observability

Conversation

@abhinav-galileo
Copy link
Copy Markdown
Collaborator

@abhinav-galileo abhinav-galileo commented May 19, 2026

Summary

  • Add AGENT_CONTROL_CONFIGURE_LOGGING, defaulting to true, so OSS/default server behavior remains unchanged.
  • When AGENT_CONTROL_CONFIGURE_LOGGING=false, Agent Control skips installing its own logging handlers.
  • In host-owned logging mode, pass log_config=None to Uvicorn so embedding hosts keep their existing logging configuration.
  • Add focused coverage for the new config setting, logging no-op behavior, and Uvicorn startup kwargs.

Usage

Default behavior is unchanged:

AGENT_CONTROL_CONFIGURE_LOGGING=true

Embedding hosts that own process logging can disable Agent Control's logging setup:

AGENT_CONTROL_CONFIGURE_LOGGING=false

With that setting disabled:

  • configure_logging() returns without changing root or Uvicorn handlers.
  • run() passes log_config=None to uvicorn.run(...).
  • Existing host logging configuration remains in place.

Validation

  • make server-test
  • uv run --package agent-control-server mypy --config-file pyproject.toml server/src
  • uv run --package agent-control-server ruff check --config pyproject.toml server/src server/tests/test_config.py server/tests/test_logging_utils.py server/tests/test_main_lifespan.py

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@abhinav-galileo abhinav-galileo force-pushed the feature/galileo-host-observability branch from 9ae0268 to 8c7ced3 Compare May 20, 2026 13:20
@abhinav-galileo abhinav-galileo marked this pull request as ready for review May 20, 2026 18:21
Comment thread server/src/agent_control_server/main.py Outdated
@abhinav-galileo abhinav-galileo merged commit c0fd159 into main May 22, 2026
6 checks passed
@abhinav-galileo abhinav-galileo deleted the feature/galileo-host-observability branch May 22, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants