feat(web): file mentions now open files in the editor#31407
Open
OnkelTem wants to merge 1 commit into
Open
Conversation
OnkelTem
force-pushed
the
feature/file-links
branch
2 times, most recently
from
9e32c16 to
e2541a3
Compare
OnkelTem
force-pushed
the
feature/file-links
branch
from
e2541a3 to
e4e8f56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31406
Type of change
What does this PR do?
paths (e.g.,
packages/app/README.md) that appear in chat messages are now rendered as clickable links. Clicking a path opens the file in the side panel editor tab.Changes
packages/ui/src/components/markdown.tsx— addedmarkFileLinks()that scans inline<code>elements (not inside<pre>) for file path patterns (contains., not an HTTP URL, no invalid path characters<>:"|?*) and wraps them in<a data-file-path="..." class="file-link">. AddedsetupFileClickhandler andonFileClickprop.packages/ui/src/components/message-part.tsx— passedonFileClickthrough the component chain toMarkdown.packages/app/src/pages/session.tsx— wiredonFileClickto open the tab, load file content, and show the side panel.How did you verify your code works?
By testing it across my sessions.
Screenshots / recordings
A screencast: https://youtu.be/OBDPo-FNuwo
Checklist