fix: drain pending events before breaking on session idle in JSON format mode#31434
Closed
jangel97 wants to merge 1 commit into
Closed
fix: drain pending events before breaking on session idle in JSON format mode#31434jangel97 wants to merge 1 commit into
jangel97 wants to merge 1 commit into
Conversation
…mat mode The loop() function in opencode run --format json breaks immediately when it receives a session.status = idle event. In containerized environments, this event races ahead of text and step-finish part events in the SSE pipeline, causing incomplete JSONL output (only step_start emitted). Track active step lifecycle with a counter. When idle arrives while steps are still open, defer the break and drain remaining events with a 3s safety timeout.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
Author
|
Created new PR with correct description format #31446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31435
opencode run --format jsonbreaks immediately onsession.status = idle, but in containerized environments the idle event races ahead oftextandstep-finishpart events in the SSE pipeline, producing incomplete JSONL output (onlystep_startemitted)Test plan
OPENCODE_EXPERIMENTAL=true opencode run --format json -m <provider/model> "Say hello"and verify all three JSONL events appear:step_start,text,step_finishopencode run "Say hello") still works as before