fix: add 5min timeout to npm reify to prevent silent deadlocks#31468
Open
7emotions wants to merge 1 commit into
Open
fix: add 5min timeout to npm reify to prevent silent deadlocks#314687emotions wants to merge 1 commit into
7emotions wants to merge 1 commit into
Conversation
Arborist reify() called by Npm.add() can deadlock silently when the npm cache is cold (resolving @latest specifiers). Adding Effect.timeout surfaces the error instead of hanging indefinitely. Related: anomalyco#23143 (@latest triggers full reify with no TTL cache)
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31463
Type of change
What does this PR do?
Npm.add()inpackages/core/src/npm.tscalls Arboristreify()when the npm cache is cold.reify()can deadlock silently with no error. This PR wraps it withEffect.timeout("5 minutes")so a hang surfaces as a visible error through the existing plugin error pipeline, instead of blocking the process indefinitely.How did you verify your code works?
Effect.timeout("5 minutes")is the same pattern already used elsewhere in the codebase ("30 seconds","10 seconds"). The timeout path cannot be triggered under normal conditions — it is a safety net for the rare deadlock case.Checklist