CAMEL-23574: docs - sync camel-dns 4.18 / 4.14 upgrade-guide entries to main#23488
Open
oscerd wants to merge 1 commit into
Open
CAMEL-23574: docs - sync camel-dns 4.18 / 4.14 upgrade-guide entries to main#23488oscerd wants to merge 1 commit into
oscerd wants to merge 1 commit into
Conversation
…to main The camel-dns header constant rename (CAMEL-23574, apache#23411) was backported to camel-4.18.x (4.18.3) via apache#23459 and to camel-4.14.x (4.14.8) via apache#23482. The version-specific upgrade-guide files on main are the canonical history, so the corresponding entries are added here on main only. Also normalises the existing 4_21 camel-dns heading to "- potential breaking change" to match the suffix convention now used across the catalog-wide header-rename family (CAMEL-23577) — e.g. camel-cxf, camel-jgroups, camel-jira, camel-aws-bedrock. Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
approved these changes
May 24, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Docs-only PR syncing the camel-dns header-rename upgrade notes to the 4.18 and 4.14 guides on main, plus normalising the 4.21 heading suffix.
What I checked:
- 4.14 & 4.18 entries: Identical content (correct — same rename applies to both lines). All 6 header renames documented accurately in a clear table format (
dns.class→CamelDnsClass, etc.). - Before/after code example: Helpful and correct — shows the literal-string migration path.
- Cross-transport propagation note: Excellent addition. Correctly explains the security-relevant behavioural side-effect:
Camel*-prefixed headers are filtered byHeaderFilterStrategy, so routes bridging external transports intodns:producers need explicit header mapping. This is a genuinely important migration caveat. - 4.21 heading normalisation:
=== camel-dns→=== camel-dns - potential breaking change— consistent with the CAMEL-23577 sweep convention used across neighbouring entries. - Placement: 4.14 entry appends after the existing camel-jgroups section (correct position within the 4.14.8 upgrade section). 4.18 entry appends after the camel-cxf section.
- No merge conflict risk with #23487: The two PRs touch different regions of
camel-4x-upgrade-guide-4_14.adoc.
LGTM.
Claude Code on behalf of Guillaume Nodet
Contributor
|
🧪 CI tested the following changed modules:
|
davsclaus
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
camel-dnsupgrade-guide entry for the header-constant rename(CAMEL-23574) to the version-specific guides on
main, matching thebackport-upgrade-guide policy (canonical guides live on
main).camel-4x-upgrade-guide-4_18.adoc— entry for users moving within 4.18.xto 4.18.3 (backport [backport camel-4.18.x] CAMEL-23574: camel-dns - align Exchange header constant names with Camel naming convention #23459, merged).
camel-4x-upgrade-guide-4_14.adoc— entry for users moving within 4.14.xto 4.14.8 (backport [backport camel-4.14.x] CAMEL-23574: camel-dns - align Exchange header constant names with Camel naming convention #23482, open).
camel-4x-upgrade-guide-4_21.adoc— the existing entry's heading isnormalised to
- potential breaking changeto match the suffix conventionnow used across the catalog-wide header-rename family (CAMEL-23577) —
e.g.
camel-cxf,camel-jgroups,camel-jira,camel-aws-bedrock.Original main PR: #23411
Backport PRs: #23459 (4.18.x, merged) · #23482 (4.14.x, open)
Test plan
- potential breaking changesuffix).Claude Code on behalf of Andrea Cosentino