Skip to content

Commit 29dcd98

Browse files
committed
Address PR comments
1 parent 9e77535 commit 29dcd98

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

examples/datafusion-ffi-example/python/tests/_test_table_provider_factory.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
from __future__ import annotations
1919

20-
import pyarrow as pa
21-
import pytest
2220
from datafusion import SessionContext
2321
from datafusion_ffi_example import MyTableProviderFactory
2422

@@ -35,7 +33,7 @@ def test_table_provider_factory_ffi() -> None:
3533
foo
3634
STORED AS my_format
3735
LOCATION '';
38-
""")
36+
""").collect()
3937

4038
# Query the pre-populated table
4139
result = ctx.sql("SELECT * FROM foo;").collect()

python/datafusion/context.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -836,12 +836,12 @@ def register_table_factory(
836836
) -> None:
837837
"""Register a :py:class:`~datafusion.TableProviderFactoryExportable`.
838838
839-
The registered factory can be reference from SQL DDL statements executed
839+
The registered factory can be referenced from SQL DDL statements executed
840840
against this context.
841841
842842
Args:
843843
format: The value to be used in `STORED AS ${format}` clause.
844-
factory: A PyCapsule that implements TableProviderFactoryExportable"
844+
factory: A PyCapsule that implements :class:`TableProviderFactoryExportable`
845845
"""
846846
self.ctx.register_table_factory(format, factory)
847847

0 commit comments

Comments
 (0)