From 7201265cb635a147afa1281045a51ac0520c07fb Mon Sep 17 00:00:00 2001 From: Xin Huang Date: Sat, 20 Jun 2026 12:59:46 -0700 Subject: [PATCH] docs: clarify stdin store buffers on construction, not first use Address review feedback on #22839: the `stdin://` store reads and buffers all of standard input eagerly when the store is constructed, not lazily on first use. Reword the get_or_create doc comment to say so. --- datafusion-cli/src/object_storage/stdin.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/datafusion-cli/src/object_storage/stdin.rs b/datafusion-cli/src/object_storage/stdin.rs index 602b00a9b90f6..c6136be3c47b7 100644 --- a/datafusion-cli/src/object_storage/stdin.rs +++ b/datafusion-cli/src/object_storage/stdin.rs @@ -99,9 +99,9 @@ impl StdinUtils { format!("{}:///{object_name}", Self::SCHEME) } - /// Returns the object store backing the `stdin://` scheme, reading and - /// buffering standard input on first use and reusing that buffer for any - /// subsequent `stdin://` table created in the same session. + /// Returns the object store backing the `stdin://` scheme, buffering all of + /// standard input when the store is first constructed and reusing that + /// buffer for any subsequent `stdin://` table created in the same session. /// /// stdin is a one-shot stream: it can only be read once. The object store /// registry keys by scheme/authority, so every `stdin://` URL maps to the