Skip to content

Commit c27b41a

Browse files
committed
[FLINK-37924][table] Update expected argument types and signatures for Variant access
1 parent 5ef9f93 commit c27b41a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ItemAtIndexArgumentTypeStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,6 @@ public Optional<DataType> inferArgumentType(
120120
public Signature.Argument getExpectedArgument(
121121
FunctionDefinition functionDefinition, int argumentPos) {
122122
return Signature.Argument.of(
123-
"[<INTEGER NUMERIC> | <MAP_KEY_TYPE> | <CHARACTER STRING> or <INTEGER NUMERIC>]");
123+
"[<CHARACTER STRING> | <INTEGER NUMERIC> | <MAP_KEY_TYPE>]");
124124
}
125125
}

flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/ItemAtIndexArgumentTypeStrategyTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ protected Stream<TestSpec> testData() {
4242
DataTypes.ARRAY(DataTypes.STRING().notNull()),
4343
DataTypes.SMALLINT().notNull())
4444
.expectSignature(
45-
"f([<ARRAY> | <MAP> | <VARIANT>], [<INTEGER NUMERIC> | <MAP_KEY_TYPE> | <CHARACTER STRING> or <INTEGER NUMERIC>])")
45+
"f([<ARRAY> | <MAP> | <VARIANT>], [<CHARACTER STRING> | <INTEGER NUMERIC> | <MAP_KEY_TYPE>])")
4646
.expectArgumentTypes(
4747
DataTypes.ARRAY(DataTypes.STRING().notNull()),
4848
DataTypes.SMALLINT().notNull()),
@@ -58,7 +58,7 @@ protected Stream<TestSpec> testData() {
5858
DataTypes.MAP(DataTypes.BIGINT(), DataTypes.STRING().notNull()),
5959
DataTypes.SMALLINT())
6060
.expectSignature(
61-
"f([<ARRAY> | <MAP> | <VARIANT>], [<INTEGER NUMERIC> | <MAP_KEY_TYPE> | <CHARACTER STRING> or <INTEGER NUMERIC>])")
61+
"f([<ARRAY> | <MAP> | <VARIANT>], [<CHARACTER STRING> | <INTEGER NUMERIC> | <MAP_KEY_TYPE>])")
6262
.expectArgumentTypes(
6363
DataTypes.MAP(DataTypes.BIGINT(), DataTypes.STRING().notNull()),
6464
DataTypes.BIGINT()),
@@ -78,7 +78,7 @@ protected Stream<TestSpec> testData() {
7878
.calledWithArgumentTypes(
7979
DataTypes.VARIANT(), DataTypes.SMALLINT().notNull())
8080
.expectSignature(
81-
"f([<ARRAY> | <MAP> | <VARIANT>], [<INTEGER NUMERIC> | <MAP_KEY_TYPE> | <CHARACTER STRING> or <INTEGER NUMERIC>])")
81+
"f([<ARRAY> | <MAP> | <VARIANT>], [<CHARACTER STRING> | <INTEGER NUMERIC> | <MAP_KEY_TYPE>])")
8282
.expectArgumentTypes(DataTypes.VARIANT(), DataTypes.SMALLINT().notNull()),
8383
TestSpec.forStrategy(
8484
"Validate incorrect index for a variant", ITEM_AT_INPUT_STRATEGY)
@@ -90,7 +90,7 @@ protected Stream<TestSpec> testData() {
9090
TestSpec.forStrategy("Validate string key for a variant", ITEM_AT_INPUT_STRATEGY)
9191
.calledWithArgumentTypes(DataTypes.VARIANT(), DataTypes.STRING().notNull())
9292
.expectSignature(
93-
"f([<ARRAY> | <MAP> | <VARIANT>], [<INTEGER NUMERIC> | <MAP_KEY_TYPE> | <CHARACTER STRING> or <INTEGER NUMERIC>])")
93+
"f([<ARRAY> | <MAP> | <VARIANT>], [<CHARACTER STRING> | <INTEGER NUMERIC> | <MAP_KEY_TYPE>])")
9494
.expectArgumentTypes(DataTypes.VARIANT(), DataTypes.STRING().notNull()),
9595
TestSpec.forStrategy(
9696
"Validate incorrect variant key for a variant",

0 commit comments

Comments
 (0)