[Velox][Build][MIRROR] Skip sudo on macOS when staging Velox Arrow patches#12129
Open
jackylee-ch wants to merge 1 commit into
Open
[Velox][Build][MIRROR] Skip sudo on macOS when staging Velox Arrow patches#12129jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
…tches apply_compilation_fixes copies two Arrow patch files into VELOX_HOME's resolve_dependency_modules/arrow/ directory. The script always uses `sudo cp`, which on macOS triggers an interactive password prompt every time the build is run, even though VELOX_HOME is normally a user-owned directory. Introduce a SUDO_CMD variable that resolves to `sudo` on Linux and an empty string elsewhere, so the cp invocations work as the regular user on macOS while preserving the existing behavior on Linux.
Contributor
Author
|
cc @zhouyuan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
apply_compilation_fixesinep/build-velox/src/get-velox.shalwayscalls
sudo cpwhen staging the two Arrow patch files into$VELOX_HOME/CMake/resolve_dependency_modules/arrow/. On macOS thetarget directory is user-owned, so the
sudotriggers an interactivepassword prompt on every build with no functional benefit.
Introduce a
SUDO_CMDvariable that resolves tosudoon Linux andan empty string elsewhere; behavior on Linux is unchanged.
How was this patch tested?
dev/builddeps-veloxbe.shno longer prompts for apassword when re-running
apply_compilation_fixes. The two patchfiles land in
$VELOX_HOME/CMake/resolve_dependency_modules/arrow/with the user's own ownership.
SUDO_CMD=sudo, identical to the previous behavior.Was this patch authored or co-authored using generative AI tooling?
co-auth: Claude (Sonnet/Opus) via Claude Code 1.x