HBASE-30174 Add start offset option to ROWPREFIX_FIXED_LENGTH bloom filter#8270
Open
jinhyukify wants to merge 1 commit into
Open
HBASE-30174 Add start offset option to ROWPREFIX_FIXED_LENGTH bloom filter#8270jinhyukify wants to merge 1 commit into
jinhyukify wants to merge 1 commit into
Conversation
Comment on lines
+426
to
432
| if (bloomType == BloomType.ROWPREFIX_FIXED_LENGTH && bloomParam != null) { | ||
| String[] parts = bloomParam.split(":"); | ||
| conf.set(BloomFilterUtil.PREFIX_LENGTH_KEY, parts[0]); | ||
| if (parts.length > 1) { | ||
| conf.set(BloomFilterUtil.PREFIX_START_OFFSET_KEY, parts[1]); | ||
| } | ||
| } |
Comment on lines
+1025
to
+1033
| String prefixLength = | ||
| familyDescriptor.getConfigurationValue(BloomFilterUtil.PREFIX_LENGTH_KEY); | ||
| String startOffset = | ||
| familyDescriptor.getConfigurationValue(BloomFilterUtil.PREFIX_START_OFFSET_KEY); | ||
| if (startOffset != null && Integer.parseInt(startOffset) > 0) { | ||
| bloomParam = prefixLength + ":" + startOffset; | ||
| } else { | ||
| bloomParam = prefixLength; | ||
| } |
Comment on lines
+277
to
+281
| int startOffset = conf.getInt(PREFIX_START_OFFSET_KEY, 0); | ||
| if (startOffset < 0) { | ||
| throw new IllegalArgumentException( | ||
| message + "the value of " + PREFIX_START_OFFSET_KEY + " must be >= 0"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira https://issues.apache.org/jira/browse/HBASE-30174