Skip to content

HBASE-30209 MobFileCleanerChore is not registered for online configur… #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuxiaocs7 wants to merge 2 commits into
base: master
Choose a base branch
from
+31 −0
Open

HBASE-30209 MobFileCleanerChore is not registered for online configur… #8324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaaba6d
HBASE-30209 MobFileCleanerChore is not registered for online configur…
liuxiaocs7 Jun 8, 2026
0981bc7
address comments
liuxiaocs7 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,7 @@ public void updateConfigurationForQuotasObserver(Configuration conf) {

private void initMobCleaner() {
this.mobFileCleanerChore = new MobFileCleanerChore(this);
configurationManager.registerObserver(this.mobFileCleanerChore);
getChoreService().scheduleChore(mobFileCleanerChore);
this.mobFileCompactionChore = new MobFileCompactionChore(this);
getChoreService().scheduleChore(mobFileCompactionChore);
Expand Down
7 changes: 7 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.apache.hadoop.hbase.master.cleaner.ReplicationBarrierCleaner;
import org.apache.hadoop.hbase.master.hbck.HbckChore;
import org.apache.hadoop.hbase.master.janitor.CatalogJanitor;
import org.apache.hadoop.hbase.mob.MobFileCleanerChore;
import org.apache.hadoop.hbase.testclassification.MasterTests;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.junit.jupiter.api.AfterAll;
Expand Down Expand Up @@ -108,6 +109,12 @@ public void testDefaultScheduledChores() throws Exception {
TestChoreField<HbckChore> hbckChoreTestChoreField = new TestChoreField<>();
HbckChore hbckChore = hbckChoreTestChoreField.getChoreObj("hbckChore");
hbckChoreTestChoreField.testIfChoreScheduled(hbckChore);

TestChoreField<MobFileCleanerChore> mobFileCleanerTestChoreField = new TestChoreField<>();
MobFileCleanerChore mobFileCleanerChore =
mobFileCleanerTestChoreField.getChoreObj("mobFileCleanerChore");
mobFileCleanerTestChoreField.testIfChoreScheduled(mobFileCleanerChore);
assertTrue(hMaster.getConfigurationManager().containsObserver(mobFileCleanerChore));
}

/**
Expand Down
23 changes: 23 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.hadoop.hbase.mob;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.mock;
Expand All @@ -34,6 +35,28 @@
@Tag(SmallTests.TAG)
public class TestMobFileCleanerChore {

@Test
public void testOnConfigurationChangeResizesExecutor() {
Configuration conf = new Configuration();
conf.setInt(MobConstants.MOB_CLEANER_THREAD_COUNT, 2);
HMaster master = mock(HMaster.class);
when(master.getServerName()).thenReturn(ServerName.valueOf("localhost", 12345, 1));
when(master.getConfiguration()).thenReturn(conf);

MobFileCleanerChore chore = new MobFileCleanerChore(master);
assertEquals(2, chore.getExecutor().getCorePoolSize());
assertEquals(2, chore.getExecutor().getMaximumPoolSize());

Configuration newConf = new Configuration(conf);
newConf.setInt(MobConstants.MOB_CLEANER_THREAD_COUNT, 4);
chore.onConfigurationChange(newConf);

assertEquals(4, chore.getExecutor().getCorePoolSize());
assertEquals(4, chore.getExecutor().getMaximumPoolSize());

chore.shutdown();
}

@Test
public void testShutdownCleansUpExecutor() {
Configuration conf = new Configuration();
Expand Down