HBASE-29774 incremental backup fails on empty WAL#8327
Open
DieterDP-ng wants to merge 1 commit into
Open
Conversation
Add handling for WALHeaderEOFException in WALInputFormat so WALPlayer now skips empty WAL files rather than crashing. Empty WAL files (also lacking a header) either originate from crashed Region Servers, or might exist for a very short period when using the legacy WAL writer on newly created active WALs. This solves a problem where incremental backups could fail when converting WAL files to HFiles. In this use case, all WAL files passed to the WALPlayer are rolled (so no longer active), so empty WAL files were due to crashed Region Servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling for WALHeaderEOFException in WALInputFormat so WALPlayer now skips empty WAL files rather than crashing. Empty WAL files (also lacking a header) either originate from crashed Region Servers, or might exist for a very short period when using the legacy WAL writer on newly created active WALs.
This solves a problem where incremental backups could fail when converting WAL files to HFiles. In this use case, all WAL files passed to the WALPlayer are rolled (so no longer active), so empty WAL files were due to crashed Region Servers.
(This is an updated PR of the one originally created by my colleague @thomassngdata. It applies some review remarks I had when reviewing that PR, but Thomas is currently unavailable to process them himself.)