Skip to content

PHOENIX-7859 Make ParallelPhoenixConnectionFallbackIT deterministic #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mnpoonia wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −7
Open

PHOENIX-7859 Make ParallelPhoenixConnectionFallbackIT deterministic #2482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1341c
PHOENIX-7859 Make ParallelPhoenixConnectionFallbackIT deterministic b…
mnpoonia May 19, 2026
1422e69
PHOENIX-7859 Increase waitFor timeouts to tolerate CI host CPU starva…
mnpoonia Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions phoenix-core/src/it/java/org/apache/phoenix/jdbc/ParallelPhoenixConnectionFallbackIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ public void testParallelConnectionBackoff() throws Exception {
CountDownLatch cdl1 = new CountDownLatch(1);
CountDownLatch cdl2 = new CountDownLatch(1);
ParallelPhoenixContext contextA = ((ParallelPhoenixConnection) connA).getContext();
waitFor(() -> contextA.getChainOnConn1().isDone(), 100, 5000);
waitFor(() -> contextA.getChainOnConn2().isDone(), 100, 5000);
waitFor(() -> contextA.getChainOnConn1().isDone(), 100, 60000);
waitFor(() -> contextA.getChainOnConn2().isDone(), 100, 60000);
contextA.chainOnConn1(getSuplierWithLatch(cdl1));
contextA.chainOnConn2(getSuplierWithLatch(cdl2));
waitFor(() -> PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(0)
&& PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(1), 100, 5000);
&& PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(1), 100, 60000);
ExecutorService executor = Executors.newFixedThreadPool(1);
// Since both the cluster executors are busy, the new connection will be
// put in the executor queue, and a connection won't be returned unless
Expand All @@ -110,7 +110,7 @@ public void testParallelConnectionBackoff() throws Exception {

// The previous call of connection creation should fill the queue by half.
waitFor(() -> !PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(0)
&& !PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(1), 100, 5000);
&& !PhoenixHAExecutorServiceProvider.hasCapacity(PROPERTIES).get(1), 100, 60000);

// This should be backed off now, as the capacity is not available.
Connection connC = DriverManager.getConnection(jdbcUrl, PROPERTIES);
Expand All @@ -122,14 +122,14 @@ public void testParallelConnectionBackoff() throws Exception {
cdl2.countDown();

// Once the previous tasks are done, we expect the futureConnB to be picked and be done.
waitFor(() -> futureConnB.isDone(), 1000, 5000);
waitFor(() -> futureConnB.isDone(), 1000, 60000);
Connection connB = futureConnB.get();
assertTrue(connB instanceof ParallelPhoenixConnection);

doTestBasicOperationsWithConnection(connB, tableName, haGroupName);
ParallelPhoenixContext contextB = ((ParallelPhoenixConnection) connB).getContext();
waitFor(() -> contextB.getChainOnConn1().isDone(), 100, 5000);
waitFor(() -> contextB.getChainOnConn2().isDone(), 100, 5000);
waitFor(() -> contextB.getChainOnConn1().isDone(), 100, 60000);
waitFor(() -> contextB.getChainOnConn2().isDone(), 100, 60000);

// Now that the queue has capacity, this should be ParallelLPhoenixConnection.
Connection connD = DriverManager.getConnection(jdbcUrl, PROPERTIES);
Expand Down