Skip to content

fix(storage): close Files.walk stream in deleteRepo to stop leak #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinsiek wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix(storage): close Files.walk stream in deleteRepo to stop leak #5575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../org/apache/texera/amber/core/storage/util/dataset/GitVersionControlLocalFileStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ public static void removeFileFromRepo(Path repoPath, Path filePath) throws IOExc
* @throws IOException If an I/O error occurs.
*/
public static void deleteRepo(Path directoryPath) throws IOException {
Files.walk(directoryPath)
.sorted(Comparator.reverseOrder())
.map(Path::toFile)
.forEach(File::delete);
try (var stream = Files.walk(directoryPath)) {
stream
.sorted(Comparator.reverseOrder())
.map(Path::toFile)
.forEach(File::delete);
}
}

/**
Expand Down