test(frontend): add unit tests for DatasetVersionSelectorComponent#5579
Open
yangzhang75 wants to merge 1 commit into
Open
test(frontend): add unit tests for DatasetVersionSelectorComponent#5579yangzhang75 wants to merge 1 commit into
yangzhang75 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds a unit test spec for DatasetVersionSelectorComponent, which previously had no *.spec.ts. The component is a Formly field type whose onClickOpenDatasetSelectionModal() opens a dataset-selection modal and writes the chosen value back into the form control when the modal closes with a value.
Any related issues, documentation, discussions?
Closes #5470
How was this PR tested?
New unit tests added in dataset-version-selector.component.spec.ts, run via
ng test(Vitest). They cover:All 4 tests pass; eslint and prettier checks are clean.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)