test: add unit tests for RowModalComponent (#5469)#5580
Open
Neilk1021 wants to merge 3 commits into
Open
Conversation
Contributor
|
@xuang7 Can you review this PR? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5580 +/- ##
============================================
+ Coverage 52.17% 52.21% +0.03%
Complexity 2482 2482
============================================
Files 1068 1068
Lines 41311 41311
Branches 4439 4439
============================================
+ Hits 21556 21570 +14
+ Misses 18490 18477 -13
+ Partials 1265 1264 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR! I think this one has the same issues as #5578. Could you please apply the same fixes here as well? |
Author
|
@xuang7 Done! I've removed the UTF-8 BOM and the redundant Vitest imports in the latest commit to match the fixes from the other PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds a comprehensive unit test suite (
result-panel-modal.component.spec.ts) for theRowModalComponent.The newly introduced test cases verify that:
NZ_MODAL_DATA,NzModalRef).ngOnChanges()executes smoothly to resolve nested service streams throughWorkflowResultServiceandPanelResizeService.currentDisplayRowDatais accurately populated with target row values evaluated from mock RxJS data streams.Any related issues, documentation, discussions?
Closes #5469
How was this PR tested?
This PR was tested by executing the newly added unit test suite (
result-panel-modal.component.spec.ts) to ensure all assertions pass successfully, validating both the dependency injection setup and the reactive stream logic.Was this PR authored or co-authored using generative AI tooling?
No