-
-
Notifications
You must be signed in to change notification settings - Fork 9
Feat transpose multiindex #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krokosik
wants to merge
8
commits into
arviz-devs:main
Choose a base branch
from
krokosik:feat-transpose-multiindex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
edfcc34
Handle transpose via rename not swap_dims
krokosik 1c8d188
Make matrix_transpose dims optional as documented
krokosik 03d4895
Add missing pinv to accessor
krokosik ed13bf4
Add a multiindex test to show there are no errors
krokosik 428a111
Update docstring
krokosik a3af36e
Apply tox fixes
krokosik e2fd7e8
Fix 1D case ;)
krokosik f95726f
Add missing matmul to accessor
krokosik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -167,6 +167,10 @@ def test_pinv_dataarray_tol(self, matrices, kind): | |||||||||
| def test_transpose(self, hermitian): | ||||||||||
| assert_equal(hermitian, matrix_transpose(hermitian, dims=("dim", "dim2"))) | ||||||||||
|
|
||||||||||
| def test_transpose_multiindex(self, matrices): | ||||||||||
| stacked = matrices.stack(batch_experiment=("batch", "experiment"), dim_dim2=("dim", "dim2")) | ||||||||||
| matrix_transpose(stacked, dims=("batch_experiment", "dim_dim2")) | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I would add some assertions in addition to checking this works. |
||||||||||
|
|
||||||||||
| def test_matrix_power(self, matrices): | ||||||||||
| out = matrix_power(matrices, 2, dims=("dim", "dim2")) | ||||||||||
| assert out.shape == matrices.shape | ||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think that the function should work even when the dimensions to transpose have a multiindex, but I am not sure about the handling of coords. I would be very interested in having your feedback and usecases. I had only considered the possibility of using this function for square matrices where there is basically a repeated dimension so I had
dim+dim2orxyz+xyz_biswith same length and same coordinate values.The function does already work on non multiindex but different length dimensions, and had I realized before, my intuition would have been to remove the coordinate values from the output in such cases. This is what sort does.
What do/would you use this changing of dim->coords pairings for?
For example, if I add coordiate values to one of the example datasets:
and after
matrix_transpose(no multiindex, I don't think it is relevant in this particular case):Having the
batchdimension now hold the experiment coordinates seems strange, independently of them having a multiindex. I was also curious about the constraint of both multiindexes having the same levels, I guess this is so the levels can also be renamed, any thoughts on swapping only the top multiindex name and not the levels?