Merge pull request #237 from askui/fix/guard-act-tools-when-no-agent-os

fix(agent): add get/locate tools to act loop only when agent_os is set

Author: mlikasam-askui

examples/model_providers.py

@@ -35,9 +35,7 @@ def try_act(agent: ComputerAgent, provider_name: str) -> None:
     """Test the act() method with a simple goal."""
     logger.info(f"Testing act() with {provider_name}")
     agent.act(
-        goal=(
-            "Open a new Chrome window and navigate to askui.com. "
-        ),
+        goal=("Open a new Chrome window and navigate to askui.com. "),
     )
 
 
@@ -116,19 +114,19 @@ def create_mixed_providers() -> AgentSettings:
 if __name__ == "__main__":
     # Define which provider configurations to test
     provider_configs = {
-        #"AskUI (default)": create_askui_providers,
-        #"Anthropic (direct)": create_anthropic_providers,
-        #"Google (Gemini)": create_google_providers,
+        # "AskUI (default)": create_askui_providers,
+        # "Anthropic (direct)": create_anthropic_providers,
+        # "Google (Gemini)": create_google_providers,
         "Mixed providers": create_mixed_providers,
     }
 
     # Select which configuration to run (change this to test different providers)
     selected_config = "AskUI (default)"
 
     for selected_config in provider_configs.keys():
-        logger.info("#"*60)
+        logger.info("#" * 60)
         logger.info(f"Running with provider configuration: {selected_config}")
-        logger.info("#"*60)
+        logger.info("#" * 60)
         settings = provider_configs[selected_config]()
 
         with ComputerAgent(settings=settings, display=1) as agent:

src/askui/agent_base.py

@@ -91,8 +91,9 @@ def __init__(
             self.act_tool_collection.add_agent_os(agent_os)
 
         # Add provider-based tools to the act loop
-        self.act_tool_collection.append_tool(self._get_tool)
-        self.act_tool_collection.append_tool(self._locate_tool)
+        if self._agent_os is not None:
+            self.act_tool_collection.append_tool(self._get_tool)
+            self.act_tool_collection.append_tool(self._locate_tool)
 
         # Settings stored at agent level (mutable)
         self.act_settings = ActSettings()

src/askui/models/openrouter/get_model.py

@@ -178,11 +178,7 @@ def get(
             raise NotImplementedError(err_msg)
 
         # Use system prompt from settings if provided, otherwise use default
-        system_prompt = (
-            get_settings.system_prompt
-            if get_settings.system_prompt
-            else SYSTEM_PROMPT_GET
-        )
+        system_prompt = get_settings.system_prompt or SYSTEM_PROMPT_GET
 
         response = self._predict(
             image_url=source.to_data_url(),

src/askui/tools/askui/askui_controller.py

@@ -1052,7 +1052,7 @@ def _send_command(self, command: Command) -> AskUIAgentOSSendResponseSchema:
             )
         except grpc.RpcError as e:
             if e.code() == grpc.StatusCode.INVALID_ARGUMENT:
-                details = e.details() if e.details() else None
+                details = e.details() or None
                 raise AskUiControllerInvalidCommandError(details) from e
             raise
 

src/askui/utils/not_given.py

@@ -7,6 +7,7 @@
     SerializerFunctionWrapHandler,
     model_serializer,
 )
+from typing_extensions import Self
 
 
 class NotGiven(BaseModel):
@@ -19,7 +20,7 @@ class NotGiven(BaseModel):
     _uuid: ClassVar[str] = str(uuid4())
     _instance: ClassVar["NotGiven | None"] = None
 
-    def __new__(cls) -> "NotGiven":
+    def __new__(cls) -> Self:
         if cls._instance is None:
             cls._instance = super().__new__(cls)
         return cls._instance