Skip to content

Commit 76d35d8

Browse files
committed
fix: address automated review feedback
1 parent d43cf78 commit 76d35d8

5 files changed

Lines changed: 5 additions & 4 deletions

File tree

packages/webui/src/client/styles/propertiesPanel.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,12 +234,13 @@
234234
}
235235

236236
.propertiespanel-pop-up__button {
237+
display: flex;
238+
align-items: center;
237239
background: #636363;
238240
padding: 10px;
239241
border-radius: 5px;
240242
border: 1px solid #7f7f7f;
241243
color: #dfdfdf;
242-
243244
gap: 0.5em;
244245

245246
font-size: 0.875em;

packages/webui/src/client/styles/rundownView.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ body.no-overflow {
208208
left: 0;
209209
bottom: 0;
210210
right: 0;
211-
212211
background: linear-gradient(
213212
-45deg,
214213
$color-status-fatal 33%,

packages/webui/src/client/ui/RundownView.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -909,6 +909,7 @@ const RundownViewContent = translateWithTracker<IPropsWithReady & ITrackedProps,
909909
}
910910

911911
private onCloseNotifications = () => {
912+
NotificationCenter.isOpen = false
912913
this.setState({
913914
isNotificationsCenterOpen: undefined,
914915
})

packages/webui/src/client/ui/SegmentTimeline/SegmentTimeline.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,6 +1022,7 @@ export class SegmentTimelineClass extends React.Component<Translated<WithTiming<
10221022
if (!hasEditableContent) return
10231023

10241024
if (!selectElementContext.isSelected(segment._id)) {
1025+
RundownViewEventBus.emit(RundownViewEvents.CLOSE_NOTIFICATIONS)
10251026
selectElementContext.clearAndSetSelection({ type: 'segment', elementId: segment._id })
10261027
} else {
10271028
selectElementContext.clearSelections()

packages/webui/src/client/ui/UserEditOperations/PropertiesPanel.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { ReadonlyDeep } from 'type-fest'
2626
import {
2727
CoreUserEditingDefinition,
2828
CoreUserEditingProperties,
29-
} from '@sofie-automation/corelib/src/dataModel/UserEditingDefinitions.js'
29+
} from '@sofie-automation/corelib/dist/dataModel/UserEditingDefinitions.js'
3030

3131
type PendingChange = DefaultUserOperationEditProperties['payload']
3232

@@ -400,7 +400,6 @@ export function hasUserEditableContent(
400400
| undefined
401401
): boolean {
402402
return !!(
403-
obj?.userEditOperations?.length ||
404403
obj?.userEditProperties?.pieceTypeProperties ||
405404
obj?.userEditProperties?.globalProperties ||
406405
obj?.userEditProperties?.operations?.length

0 commit comments

Comments
 (0)