Skip to content

feat(fonts): support comic sans #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tjuanitas wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(fonts): support comic sans #4576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/elements/common/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@import '../../styles/inputs';

$font: lato, 'Helvetica Neue', helvetica, arial, sans-serif;
$fontComicSans: 'Comic Sans MS', cursive;
$minimumWidth: 300px;
$sidebarHeaderHeight: 60px;
$sidebarSubHeaderHeight: 56px;
Expand All @@ -28,6 +29,10 @@ $sidebarTabResponsiveSize: 48px;
/* stylelint-enable declaration-no-important */
font-family: $font;

:where(body.is-comic-sans) & {
font-family: $fontComicSans;
}

* {
@include rendering;

Expand All @@ -54,4 +59,8 @@ $sidebarTabResponsiveSize: 48px;
// Firefox sets opacity for placeholder to less than 100%
// See https://developer.mozilla.org/en-US/docs/Web/CSS/::placeholder#opaque_text
opacity: 1;

:where(body.is-comic-sans) & {
font-family: $fontComicSans;
}
}
5 changes: 5 additions & 0 deletions src/styles/mixins/_typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@

@mixin font-family {
font-family: Lato, 'Helvetica Neue', Helvetica, Arial, sans-serif;

&:where(body.is-comic-sans),
:where(body.is-comic-sans) & {
font-family: 'Comic Sans MS', cursive;
}
}

@mixin font-aliasing {
Expand Down
Loading