Tooling & typecheck

[marcalexiei]

Follow-up: #98 (comment)

Tooling

• Formatter: oxfmt (Add oxfmt to the repo #100)
• Linter: oxlint (Add oxlint to the repo #102)

Opening this issue as a reminder to work on this once #98 is completed, and to clarify a couple of related points:

Questions

1. Type checking strategy
   Given that we’re using oxlint, there are two possible approaches:

   • Maintain a separate typecheck script using tsc
   • Enable oxlint options.typecheck and report typescript diagnostics alongside lint errors

2. Additional code checks
   Should we also integrate knip to detect unused files, exports, and dependencies?

[marcalexiei]

Hello @Andarist!
PR #100 has been merged, so I’ll start working on integrating oxlint into the repository when I have some time.
When you get a chance, could you please take a look at the questions above and let me know your thoughts?

[Andarist]

Enable oxlint options.typecheck and report typescript diagnostics alongside lint errors

out of curiosity - can we avoid typechecking within oxlint while benefitting from type-aware rules?

Should we also integrate knip to detect unused files, exports, and dependencies?

sure, the more the merries, we can add that in a separate PR

[marcalexiei]

sure, the more the merries, we can add that in a separate PR

Ok! I'll work on that after adding oxlint to the repo.

---

can we avoid typechecking within oxlint while benefitting from type-aware rules?

Yes, there are 2 separate options:

• options.typeAware Only enable rules that require type information.
• options.typeCheck enables diagnostics from typescript to be reported.
  It cannot be set to true unless typeAware is set to true.

Example output with both lint and typecheck errors

---

No longer relevant: I upgraded Typescript to 6.0.2 and no error are present

I noticed that the typescript version in this repo is a little older:

bot/package.json

Line 35 in 6b5ebbc

"typescript": "^4.7.4"

Maybe it’s better to first update typescript, and then add oxlint with type-aware rules to avoid discrepancies with oxlint-tsgolint, which relies on the newer implementation.

After updating typescript, we can add oxlint and decide whether to keep linting separate from type checking or have oxlint handle both.