Skip to content

Commit 3f56b04

Browse files
feat(studio): remove delete from projects list items (supabase#43248)
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Less destructive action on Projects List.
1 parent 36137c7 commit 3f56b04

2 files changed

Lines changed: 10 additions & 26 deletions

File tree

apps/studio/components/interfaces/Home/ProjectList/ProjectCard.tsx

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { DeleteProjectModal } from 'components/interfaces/Settings/General/DeleteProjectPanel/DeleteProjectModal'
21
import CardButton from 'components/ui/CardButton'
32
import { ComputeBadgeWrapper } from 'components/ui/ComputeBadgeWrapper'
43
import type { IntegrationProjectConnection } from 'data/integrations/integrations.types'
@@ -8,8 +7,8 @@ import type { ResourceWarning } from 'data/usage/resource-warnings-query'
87
import { useCustomContent } from 'hooks/custom-content/useCustomContent'
98
import { useIsFeatureEnabled } from 'hooks/misc/useIsFeatureEnabled'
109
import { BASE_PATH } from 'lib/constants'
11-
import { Copy, Github, MoreVertical, Trash } from 'lucide-react'
12-
import { useState } from 'react'
10+
import { Copy, Github, MoreVertical, Settings } from 'lucide-react'
11+
import { useRouter } from 'next/router'
1312
import InlineSVG from 'react-inlinesvg'
1413
import { toast } from 'sonner'
1514
import type { Organization } from 'types'
@@ -38,14 +37,13 @@ export interface ProjectCardProps {
3837
export const ProjectCard = ({
3938
slug,
4039
project,
41-
organization,
4240
rewriteHref,
4341
githubIntegration,
4442
vercelIntegration,
4543
resourceWarnings,
4644
}: ProjectCardProps) => {
45+
const router = useRouter()
4746
const { name, ref: projectRef } = project
48-
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false)
4947

5048
const { infraAwsNimbusLabel } = useCustomContent(['infra:aws_nimbus_label'])
5149
const providerLabel =
@@ -104,11 +102,11 @@ export const ProjectCard = ({
104102
className="gap-x-2"
105103
onClick={(e) => {
106104
e.stopPropagation()
107-
setIsDeleteModalOpen(true)
105+
router.push(`/project/${projectRef}/settings/general`)
108106
}}
109107
>
110-
<Trash size={14} />
111-
<span>Delete project</span>
108+
<Settings size={14} />
109+
<span>Settings</span>
112110
</DropdownMenuItem>
113111
</DropdownMenuContent>
114112
</DropdownMenu>
@@ -156,12 +154,6 @@ export const ProjectCard = ({
156154
containerElement={<ProjectIndexPageLink projectRef={projectRef} />}
157155
/>
158156
</li>
159-
<DeleteProjectModal
160-
visible={isDeleteModalOpen}
161-
onClose={() => setIsDeleteModalOpen(false)}
162-
project={project}
163-
organization={organization}
164-
/>
165157
</>
166158
)
167159
}

apps/studio/components/interfaces/Home/ProjectList/ProjectTableRow.tsx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Github, MoreVertical, Trash, Copy, Check } from 'lucide-react'
1+
import { Github, MoreVertical, Settings, Copy, Check } from 'lucide-react'
22
import { useRouter } from 'next/router'
33
import InlineSVG from 'react-inlinesvg'
44
import { useState } from 'react'
@@ -22,7 +22,6 @@ import {
2222
import { TimestampInfo } from 'ui-patterns'
2323
import { inferProjectStatus } from './ProjectCard.utils'
2424
import { ProjectCardStatus } from './ProjectCardStatus'
25-
import { DeleteProjectModal } from 'components/interfaces/Settings/General/DeleteProjectPanel/DeleteProjectModal'
2625
import { toast } from 'sonner'
2726
import { copyToClipboard } from 'ui'
2827

@@ -46,7 +45,6 @@ export const ProjectTableRow = ({
4645
const router = useRouter()
4746
const { name, ref: projectRef } = project
4847
const projectStatus = inferProjectStatus(project.status)
49-
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false)
5048
const [isCopied, setIsCopied] = useState(false)
5149

5250
const url = rewriteHref ?? `/project/${project.ref}`
@@ -177,23 +175,17 @@ export const ProjectTableRow = ({
177175
className="gap-x-2"
178176
onClick={(e) => {
179177
e.stopPropagation()
180-
setIsDeleteModalOpen(true)
178+
router.push(`/project/${projectRef}/settings/general`)
181179
}}
182180
>
183-
<Trash size={14} />
184-
<span>Delete project</span>
181+
<Settings size={14} />
182+
<span>Settings</span>
185183
</DropdownMenuItem>
186184
</DropdownMenuContent>
187185
</DropdownMenu>
188186
</div>
189187
</TableCell>
190188
</TableRow>
191-
<DeleteProjectModal
192-
visible={isDeleteModalOpen}
193-
onClose={() => setIsDeleteModalOpen(false)}
194-
project={project}
195-
organization={organization}
196-
/>
197189
</>
198190
)
199191
}

0 commit comments

Comments
 (0)