add rejectOnError

Author: kobenguyent

docs/helpers/REST.md

@@ -31,6 +31,7 @@ Type: [object][3]
 *   `onRequest` **[function][6]?** an async function which can update request object.
 *   `onResponse` **[function][6]?** an async function which can update response object.
 *   `maxUploadFileSize` **[number][4]?** set the max content file size in MB when performing api calls.
+*   `rejectOnErrorCode` **[boolean][5]?** reject promise when status code is 4xx or 5xx.
 
 
 

lib/helper/REST.js

@@ -17,6 +17,7 @@ import { beautify } from '../utils.js'
  * @prop {function} [onRequest] - an async function which can update request object.
  * @prop {function} [onResponse] - an async function which can update response object.
  * @prop {number} [maxUploadFileSize] - set the max content file size in MB when performing api calls.
+ * @prop {boolean} [rejectOnErrorCode=false] - reject promise when status code is 4xx or 5xx.
  */
 const config = {}
 
@@ -102,6 +103,7 @@ class REST extends Helper {
       prettyPrintJson: false,
       onRequest: null,
       onResponse: null,
+      rejectOnErrorCode: false,
     }
 
     // Merge config with defaults
@@ -289,6 +291,9 @@ class REST extends Helper {
         } catch (e) {
           console.log('[REST] Response error. Status code:', fetchResponse.status)
         }
+        if (this.options.rejectOnErrorCode) {
+          throw new Error(`Response error. Status code: ${fetchResponse.status}`)
+        }
       }
     } catch (err) {
       if (err.name === 'TimeoutError' || err.name === 'AbortError') {

test/rest/REST_test.js

@@ -138,6 +138,16 @@ describe('REST', () => {
         e.message.should.contain('Request timed out after 100ms')
       }
     })
+
+    it('should throw error when status code is 4xx or 5xx and rejectOnErrorCode is true', async () => {
+      I.options.rejectOnErrorCode = true
+      try {
+        await I.sendGetRequest('/not-existing-endpoint')
+        throw new Error('Should have thrown error')
+      } catch (e) {
+        e.message.should.contain('Response error. Status code: 404')
+      }
+    })
   })
 
   describe('JSONResponse integration', () => {
@@ -342,7 +352,7 @@ describe('REST - Form upload', () => {
       }
     })
 
-    it('should not show error when file size doesnt exceedes the permit', async () => {
+    it('should not show error when file size doesnt exceeds the permit', async () => {
       const form = new FormData()
       form.append('file', fs.createReadStream(testFile))