feat(Footer): allow ReactNode for categoryName to support lang attribute#493
Open
inscomssb wants to merge 1 commit into
Open
feat(Footer): allow ReactNode for categoryName to support lang attribute#493inscomssb wants to merge 1 commit into
inscomssb wants to merge 1 commit into
Conversation
…te (RGAA 8.7) Fixes codegouvfr#476 — widens `FooterProps.LinkList.Column.categoryName` from `string` to `ReactNode` so consumers can wrap content with a `lang` attribute to signal language changes in the source code, as required by RGAA criterion 8.7. Change is fully backwards-compatible since `string` is a valid `ReactNode`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476
widens the type of
FooterProps.LinkList.Column.categoryNamefromstringto
ReactNode, allowing consumers to wrap content with alangattributeto signal language changes in the source code, as required by RGAA
criterion 8.7.
the change is fully backwards compatible since
stringis a validReactNode.a new Storybook story
WithLinkListAndLangOnCategoryNamedemonstratesthe use case.