flake: TestPortableDesktop_StopRecording_WithThumbnail

[flake-investigator]

CI Run Link: https://github.com/coder/coder/actions/runs/24250265854
Failing Job: https://github.com/coder/coder/actions/runs/24250265854/job/70807474161 (test-go-pg (macos-latest))
Commit: e0fbb0e4ecb8ecb33220158ba69dac16155e1c48 (Garrett Delfosse) coder/coder@e0fbb0e

Failure summary:

• TestPortableDesktop_StopRecording_WithThumbnail failed on macOS only.
• Error output:

FAIL: agent/x/agentdesktop TestPortableDesktop_StopRecording_WithThumbnail
portabledesktop_internal_test.go:716:
    Error: Received unexpected error:
        recording corrupted: process was force-killed:
            github.com/coder/coder/v2/agent/x/agentdesktop.init
                <autogenerated>:1

• The error maps to ErrRecordingCorrupted in agent/x/agentdesktop/portabledesktop.go, which is returned when StopRecording has to SIGKILL the recording process (timeout or ctx cancel) instead of a graceful exit.

Root cause classification: Flaky test (recording subprocess didn’t exit cleanly on macOS; StopRecording forced a kill, causing ErrRecordingCorrupted).

Precise assignment analysis:

• Expected blame: git blame -L 680,760 agent/x/agentdesktop/portabledesktop_internal_test.go (failing test function).
• Tooling fallback used: git log --oneline -10 --follow agent/x/agentdesktop/portabledesktop_internal_test.go
  • Most recent substantive change: efb19eb (Hugo Dutka) “feat: agents desktop recording thumbnail backend”.
• Component context: git log --oneline -20 agent/x/agentdesktop shows the same ownership around desktop recording changes.
• Assigning to Hugo Dutka as the most recent meaningful modifier of the test/component.

Reproduction (best effort):

• go test ./agent/x/agentdesktop -run TestPortableDesktop_StopRecording_WithThumbnail -count=50 on macOS

Notes:

• No panic/OOM/race indicators in logs.