From 3742eeba9cb51707f0aa574b70d86664c596d2c9 Mon Sep 17 00:00:00 2001 From: Tim Fischbach Date: Fri, 20 Mar 2026 11:46:35 +0100 Subject: [PATCH] Fix inline image collapse when file is not ready Use the file's width to determine whether actual dimensions are available instead of just checking file presence. An unprocessed image file exists but has no dimensions yet, causing the aspect ratio fallback to be skipped and the image to collapse to zero height. --- .../inlineImage/InlineImage-spec.js | 18 ++++++++++++++++++ .../contentElements/inlineImage/InlineImage.js | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/entry_types/scrolled/package/spec/contentElements/inlineImage/InlineImage-spec.js b/entry_types/scrolled/package/spec/contentElements/inlineImage/InlineImage-spec.js index 2c563fae9c..0279c72d6c 100644 --- a/entry_types/scrolled/package/spec/contentElements/inlineImage/InlineImage-spec.js +++ b/entry_types/scrolled/package/spec/contentElements/inlineImage/InlineImage-spec.js @@ -337,5 +337,23 @@ describe('InlineImage', () => { const contentElement = getContentElement(); expect(contentElement.getFitViewportAspectRatio()).toEqual('0.75'); }); + + it('uses default aspect ratio when file is not ready', () => { + const {getContentElement} = renderContentElement({ + typeName: 'inlineImage', + configuration: { + id: 100 + }, + imageFiles: [{ + permaId: 100, + isReady: false, + width: null, + height: null + }] + }); + + const contentElement = getContentElement(); + expect(contentElement.getFitViewportAspectRatio()).toEqual('0.75'); + }); }); }); diff --git a/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js b/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js index fd13dd2b3e..a00cc59e81 100644 --- a/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js +++ b/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js @@ -90,7 +90,7 @@ function ImageWithCaption({ return (