fix: promptSudo for all reporter types

Author: kevinwang5658

src/common/base-command.ts

@@ -44,9 +44,6 @@ export abstract class BaseCommand extends Command {
     ctx.on(Event.SUDO_REQUEST, async (pluginName: string, data: SudoRequestData) => {
       try {
         const password = (flags.sudoPassword) ?? (await this.reporter.promptSudo(pluginName, data, flags.secure));
-        if (!password) {
-          throw new Error(`Unable to get sudo password to run command: ${data.command}`);
-        }
 
         const result = await SudoUtils.runCommand(data.command, data.options, flags.secure, pluginName, password)
         ctx.sudoRequestGranted(pluginName, result);

src/ui/reporters/json-reporter.ts

@@ -35,7 +35,7 @@ export class JsonReporter implements Reporter {
     }
 
     async promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<SudoRequestResponseData> {
-      throw new Error(`Json reporter error: sudo required for command: ${data.command}. Make sure to preconfigure the sudo password for the Json reporter`);
+      throw new Error(`Json reporter error: sudo required for command: ${data.command}. Make sure to preconfigure the sudo password for the Json reporter using --sudoPassword`);
     }
 
     async promptUserForValues(resources: ResourceInfo[], promptType: PromptType): Promise<ResourceConfig[]> {

src/ui/reporters/plain-reporter.ts

@@ -102,9 +102,9 @@ export class PlainReporter implements Reporter {
     }
   }
 
-  async promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<SudoRequestResponseData> {
+  async promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<string | undefined> {
     console.log(chalk.blue(`Plugin: "${pluginName}" requires root access to run command: "${data.command}"`));
-    return SudoUtils.runCommand(data.command, data.options, secureMode, pluginName);
+    return undefined;
   }
 
   async promptConfirmation(message: string): Promise<boolean> {

test/orchestrator/mocks/reporter.ts

@@ -57,11 +57,8 @@ export class MockReporter implements Reporter {
     return this.config?.promptConfirmation?.() ?? true;
   }
 
-  async promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<SudoRequestResponseData> {
-    return {
-      status: SpawnStatus.SUCCESS,
-      data: '',
-    }
+  async promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<string | undefined> {
+    return '';
   }
 
   async promptUserForValues(resourceInfo: ResourceInfo[], promptType: PromptType): Promise<ResourceConfig[]> {