fix: Bug fix for MacOS oclif installer bug. It doesn't clear the oclif update plugin directory so older versions are still usable after re-installing

Author: kevinwang5658

scripts/pkg.ts

@@ -1,6 +1,7 @@
 import chalk from 'chalk'
 import { execSync } from 'node:child_process'
 import fs from 'node:fs/promises'
+import path from 'node:path';
 
 console.log(chalk.magenta('Removing everything in ./.build except tmp'))
 await fs.readdir('./.build')
@@ -28,7 +29,8 @@ console.log(chalk.magenta('Install production dependencies'))
 execSync('npm install --production', { cwd: './.build', shell: 'zsh' })
 
 console.log(chalk.magenta('Running oclif pkg macos'))
-execSync('oclif pack macos -r .', { cwd: './.build', shell: 'zsh' })
+execSync('oclif pack macos -r .', { cwd: './.build', shell: 'zsh' });
+await patchMacOsInstallers()
 
 console.log(chalk.magenta('Running oclif pkg tarballs'))
 execSync('oclif pack tarballs -r . -t darwin-arm64,darwin-x64', { cwd: './.build', shell: 'zsh' })
@@ -44,3 +46,24 @@ async function ignoreError(fn: () => Promise<any> | any): Promise<void> {
   } catch (e) {
   }
 }
+
+// Oclif has a bug where the installer doesn't clear out the auto-updater location. This causes older versions
+// to be re-used even with a clean install
+async function patchMacOsInstallers() {
+  console.log(chalk.magenta('Patching MacOS installers with bug fix'))
+
+  const pkgFolder = './.build/dist/macos';
+  const files = await fs.readdir(pkgFolder)
+  const pkgFiles = files.filter((name) => name.endsWith('.pkg'))
+
+  for (const pkgFile of pkgFiles) {
+    const pkgPath = path.join(pkgFolder, pkgFile);
+    const tmpPath = path.join(pkgFolder, 'tmp');
+
+    execSync(`pkgutil --expand ${pkgPath} ${tmpPath}`)
+    await fs.appendFile(path.join(tmpPath, 'Scripts', 'preinstall'), '\nsudo rm -rf ~/.local/share/codify', 'utf8');
+    execSync(`pkgutil --flatten ${tmpPath} ${pkgPath} `)
+    execSync(`rm -rf ${tmpPath}`);
+    console.log(chalk.magenta(`Done patching installer ${pkgFile}`))
+  }
+}

src/connect/http-routes/handlers/refresh-handler.ts

@@ -30,7 +30,7 @@ export function refreshHandler() {
     }
 
     if (type === RefreshType.REFRESH_SPECIFIC && (!resourceTypes || !Array.isArray(resourceTypes))) {
-      throw new Error('For refresh specific, a list of resource types must be provided');
+      throw new Error(`For refresh specific, a list of resource types must be provided, received: ${resourceTypes}`);
     }
 
     if (!validator(codifyConfig)) {