fix(yaml-config): address PR #1966 reviewer feedback

* rename json_file -> yaml_file context-manager var

* force UTF-8 for YAML writes (YAML 1.2 spec mandates UTF-8/16/32) to avoid UnicodeEncodeError when self._settings.encoding is non-UTF-8

* tighten regression test to reject any \Uxxxxxxxx escape (case-insensitive)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: bearomorphism

commitizen/config/yaml_config.py

@@ -27,11 +27,10 @@ def __init__(self, *, data: bytes | str, path: Path) -> None:
         self._parse_setting(data)
 
     def init_empty_config_content(self) -> None:
-        with smart_open(
-            self.path, "a", encoding=self._settings["encoding"]
-        ) as json_file:
+        # Write YAML as UTF-8; YAML 1.2 requires UTF-8/16/32.
+        with smart_open(self.path, "a", encoding="utf-8") as yaml_file:
             yaml.dump(
-                {"commitizen": {}}, json_file, explicit_start=True, allow_unicode=True
+                {"commitizen": {}}, yaml_file, explicit_start=True, allow_unicode=True
             )
 
     def contains_commitizen_section(self) -> bool:
@@ -62,9 +61,8 @@ def set_key(self, key: str, value: object) -> Self:
             config_doc = yaml.load(yaml_file, Loader=yaml.FullLoader)
 
         config_doc["commitizen"][key] = value
-        with smart_open(
-            self.path, "w", encoding=self._settings["encoding"]
-        ) as yaml_file:
+        # Write YAML as UTF-8; YAML 1.2 requires UTF-8/16/32.
+        with smart_open(self.path, "w", encoding="utf-8") as yaml_file:
             yaml.dump(config_doc, yaml_file, explicit_start=True, allow_unicode=True)
 
         return self

tests/test_conf.py

@@ -2,6 +2,7 @@
 
 import json
 import os
+import re
 from pathlib import Path
 from typing import Any
 
@@ -514,7 +515,7 @@ def test_set_key_preserves_unicode(self, tmp_path, config_file):
 
         rewritten = path.read_text(encoding="utf-8")
         assert "🚀" in rewritten
-        assert "\\U0001F680" not in rewritten
+        assert not re.search(r"\\U[0-9a-fA-F]{8}", rewritten)
 
     def test_init_empty_config_content_passes_allow_unicode(
         self, tmp_path, config_file, mocker