Problem logging with non ascii characters in the password

[drc0]

also see this: https://code.google.com/p/connectbot/issues/detail?id=516

[aelmahmoudy]

Adding description, since Google code URL is no longer valid.

What steps will reproduce the problem? 

1. Change your password the one that includes non-ASCII characters, like é,   ł, đ, etc. 
2. Try to log in with password authentication. 
3. You'll get a password failed message. 
   What is the expected output?
   What do you see instead? 
   You should be able to log in with a correct password, even if it contains   non-ASCII characters. Instead, you get a password failed message in   ConnectBot and in the security log of the host. 
   What version of the product are you using (you can see this by using Menu -> About in the Host List)? 
   v1.7.1 2010.10.08 It's the most recent version from the Market as far as I know. 
   What type of system are you trying to connect to? I tried to connect to Ubuntu 11.04 and Fedora 15. These systems use UTF-8 encoding, just like ConnectBot. 

[aelmahmoudy]

Looking at the sources, it looks like a problem in   src/com/trilead/ssh2/packets/PacketUserauthRequestPassword.java line 62,   tw.writeString() is not using whatever the current code page is set to.   Same for the username. In general it is utf-8 but let's not assume that. The problem is in src/com/trilead/ssh2/packets/TypesWriter.java line 139,   it's assuming ISO-8859-1 all the time. I guess PacketUserauthRequestPassword should be constructed with the   connection's encoding and encodes the string in the correct code page   itself. Does this makes sense?