feat(cgroup1): skip cgroup1 update operation if not configured in LinuxResources

Signed-off-by: Derek Ray <derek9ray@gmail.com>

Author: derekhjray

cgroup1/blkio.go

@@ -85,6 +85,10 @@ func (b *blkioController) Create(path string, resources *specs.LinuxResources) e
 }
 
 func (b *blkioController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.BlockIO == nil {
+		return nil
+	}
+
 	return b.Create(path, resources)
 }
 

cgroup1/cpu.go

@@ -96,6 +96,10 @@ func (c *cpuController) Create(path string, resources *specs.LinuxResources) err
 }
 
 func (c *cpuController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.CPU == nil || (resources.CPU.Shares == nil && resources.CPU.Period == nil && resources.CPU.Quota == nil) {
+		return nil
+	}
+
 	return c.Create(path, resources)
 }
 

cgroup1/cpuset.go

@@ -82,6 +82,10 @@ func (c *cpusetController) Create(path string, resources *specs.LinuxResources)
 }
 
 func (c *cpusetController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.CPU == nil || (resources.CPU.Cpus == "" && resources.CPU.Mems == "") {
+		return nil
+	}
+
 	return c.Create(path, resources)
 }
 

cgroup1/devices.go

@@ -72,6 +72,10 @@ func (d *devicesController) Create(path string, resources *specs.LinuxResources)
 }
 
 func (d *devicesController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.Devices == nil {
+		return nil
+	}
+
 	return d.Create(path, resources)
 }
 

cgroup1/memory.go

@@ -210,9 +210,10 @@ func (m *memoryController) Create(path string, resources *specs.LinuxResources)
 }
 
 func (m *memoryController) Update(path string, resources *specs.LinuxResources) error {
-	if resources.Memory == nil {
+	if resources == nil || resources.Memory == nil {
 		return nil
 	}
+
 	g := func(v *int64) bool {
 		return v != nil && *v > 0
 	}

cgroup1/net_cls.go

@@ -57,5 +57,9 @@ func (n *netclsController) Create(path string, resources *specs.LinuxResources)
 }
 
 func (n *netclsController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.Network == nil {
+		return nil
+	}
+
 	return n.Create(path, resources)
 }

cgroup1/pids.go

@@ -59,6 +59,10 @@ func (p *pidsController) Create(path string, resources *specs.LinuxResources) er
 }
 
 func (p *pidsController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.Pids == nil {
+		return nil
+	}
+
 	return p.Create(path, resources)
 }
 

cgroup1/rdma.go

@@ -78,6 +78,10 @@ func (p *rdmaController) Create(path string, resources *specs.LinuxResources) er
 }
 
 func (p *rdmaController) Update(path string, resources *specs.LinuxResources) error {
+	if resources == nil || resources.Rdma == nil {
+		return nil
+	}
+
 	return p.Create(path, resources)
 }