Skip to content

Remove phpdbg from coverage target#53

Merged
f3l1x merged 1 commit into
contributte:masterfrom
ohmyfelix:chore/coverage-use-php
Mar 16, 2026
Merged

Remove phpdbg from coverage target#53
f3l1x merged 1 commit into
contributte:masterfrom
ohmyfelix:chore/coverage-use-php

Conversation

@ohmyfelix
Copy link
Copy Markdown
Contributor

Summary

Replace the coverage target in Makefile to run Tester with php instead of phpdbg.

Motivation

This aligns contributte/comgate with contributte/contributte#73 so coverage runs no longer depend on phpdbg.

Changes

  • switch both coverage target variants from -p phpdbg to -p php

Testing

  • make coverage attempted locally
  • Coverage run completes locally
  • CI passes

Local blocker: on PHP 8.5.3, make coverage currently fails inside nette/tester with Using null as an array offset is deprecated in vendor/nette/tester/src/Framework/Dumper.php:422 before coverage output is produced.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.81%. Comparing base (137d851) to head (66ded55).
⚠️ Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (137d851) and HEAD (66ded55). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (137d851) HEAD (66ded55)
5 2
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   67.18%   60.81%   -6.38%     
==========================================
  Files          15       15              
  Lines         256      222      -34     
==========================================
- Hits          172      135      -37     
- Misses         84       87       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f3l1x f3l1x marked this pull request as ready for review March 16, 2026 19:10
@f3l1x f3l1x merged commit 7baaa2b into contributte:master Mar 16, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants