From 4dc851243155b19e0bb9b3b811559e40ce02dac6 Mon Sep 17 00:00:00 2001 From: Ben Ye Date: Wed, 6 May 2026 05:38:07 +0000 Subject: [PATCH] fix(integration): Fix flaky TestGRPCCompression by waiting for missing metrics Add e2e.WaitMissingMetrics option to the WaitSumMetricsWithOptions call so the test retries when cortex_ring_members is not yet exposed by the distributor, rather than failing immediately with 'metric not found'. Signed-off-by: Ben Ye --- integration/grpc_compression_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/integration/grpc_compression_test.go b/integration/grpc_compression_test.go index ac83158da0..0134c6aecf 100644 --- a/integration/grpc_compression_test.go +++ b/integration/grpc_compression_test.go @@ -43,7 +43,8 @@ func TestGRPCCompression(t *testing.T) { require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_ring_members"}, e2e.WithLabelMatchers( labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"), - labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")))) + labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")), + e2e.WaitMissingMetrics)) c, err := e2ecortex.NewClient(distributor.HTTPEndpoint(), querier.HTTPEndpoint(), "", "", userID) require.NoError(t, err) @@ -95,7 +96,8 @@ func TestGRPCCompression(t *testing.T) { require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_ring_members"}, e2e.WithLabelMatchers( labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"), - labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")))) + labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")), + e2e.WaitMissingMetrics)) c, err := e2ecortex.NewClient(distributor.HTTPEndpoint(), querier.HTTPEndpoint(), "", "", userID) require.NoError(t, err)