From d20927b21d9f35b0381a825113e1549fed5f2af7 Mon Sep 17 00:00:00 2001 From: Andrey Kolkov Date: Fri, 12 Jun 2026 13:09:53 +0400 Subject: [PATCH] fix(ci): attach assets when release changed form draft to published Signed-off-by: Andrey Kolkov --- .github/workflows/release-assets.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-assets.yml b/.github/workflows/release-assets.yml index 1e853381..62646ac0 100644 --- a/.github/workflows/release-assets.yml +++ b/.github/workflows/release-assets.yml @@ -1,15 +1,23 @@ name: Upload release assets -# When a GitHub release is created for a tag, render the install manifests for -# that tag's image and attach them to the release. `make build-dist-manifests` -# is `helm template` of the chart with image.repository/tag set to the released +# When a GitHub release is published, render the install manifests for that +# tag's image and attach them to the release. `make build-dist-manifests` is +# `helm template` of the chart with image.repository/tag set to the released # ref; the chart renders image == OPERATOR_IMAGE, so the attached YAML deploys # the matching operator and its snapshot/restore agent. For consumers who # kubectl-apply rather than helm-install. +# +# Trigger is `published`, NOT `created`: the intended flow is release-drafter +# maintaining a draft that a maintainer then publishes, and the `created` +# activity type does NOT fire when a draft is published (only `published` +# does). With `created` the assets silently never attach for any draft-based +# release. `published` also covers a release created already-public. The +# manual `workflow_dispatch` (run against the tag ref) is the backfill path +# for a release that was published before this fix. on: release: - types: [ created ] + types: [ published ] workflow_dispatch: env: