Skip to content

Commit f5e6162

Browse files
devchenyandevchenyan
committed
1
1 parent 9566a4d commit f5e6162

14 files changed

Lines changed: 133 additions & 48 deletions

File tree

‎packages/neuron-ui/src/components/HistoryDetailPage/index.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ const HistoryDetailPage = () => {
289289
title: t('transaction.address'),
290290
dataIndex: 'type',
291291
align: 'left',
292-
width: '560px',
292+
width: '600px',
293293
render: (_, __, item) => {
294294
const { address } = handleListData(item)
295295
return (

‎packages/neuron-ui/src/components/MultisigAddress/index.tsx‎

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
useGoBack,
88
useOnWindowResize,
99
calculateFee,
10+
clsx,
1011
} from 'utils'
1112
import appState from 'states/init/app'
1213
import { useState as useGlobalState } from 'states'
@@ -22,6 +23,7 @@ import Table from 'widgets/Table'
2223
import Tooltip from 'widgets/Tooltip'
2324
import Toast from 'widgets/Toast'
2425
import AlertDialog from 'widgets/AlertDialog'
26+
import CopyZone from 'widgets/CopyZone'
2527
import {
2628
Download,
2729
Search,
@@ -39,6 +41,8 @@ import {
3941
DAOWithdrawal,
4042
Attention,
4143
Regenerate,
44+
LockCodeHash,
45+
Copy,
4246
} from 'widgets/Icons/icon'
4347
import { getHeader } from 'services/chain'
4448
import AttentionCloseDialog from 'widgets/Icons/Attention.png'
@@ -372,9 +376,8 @@ const MultisigAddress = () => {
372376
<button
373377
type="button"
374378
onClick={() => openExternal('https://github.com/Magickbase/neuron-public-issues/issues/457')}
375-
>
376-
{' '}
377-
</button>,
379+
aria-label=" "
380+
/>,
378381
]}
379382
/>
380383
</div>
@@ -437,8 +440,30 @@ const MultisigAddress = () => {
437440
render(_, __, item) {
438441
return (
439442
<div className={styles.address}>
443+
<Tooltip
444+
tip={
445+
<div>
446+
<div className={styles.titleWrap}>
447+
<p>Code_hash</p>
448+
<div className={clsx(styles.tag, item.isLegacy && styles.legacy)}>
449+
{item.isLegacy ? 'Legacy' : 'Recommended'}
450+
</div>
451+
</div>
452+
<CopyZone content={item.lockCodeHash} className={styles.copyLockCodeHash}>
453+
{item.lockCodeHash}
454+
<Copy />
455+
</CopyZone>
456+
</div>
457+
}
458+
isTriggerNextToChild
459+
tipClassName={styles.lockCodeHashTip}
460+
>
461+
<div className={clsx(styles.lockCodeHash, item.isLegacy && styles.legacy)}>
462+
<LockCodeHash />
463+
<span>@{item.lockCodeHash.slice(2, 10)}</span>
464+
</div>
465+
</Tooltip>
440466
{item.fullPayload.slice(0, 5)}...{item.fullPayload.slice(-5)}
441-
{item.isLegacy && <div className={styles.legacy}>Legacy</div>}
442467
</div>
443468
)
444469
},

‎packages/neuron-ui/src/components/MultisigAddress/multisigAddress.module.scss‎

Lines changed: 51 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
height: 44px;
1616
border-bottom: 1px solid var(--warn-border-color);
1717
padding: 0 16px;
18-
max-width: 648px;
18+
max-width: 780px;
1919
& > svg {
2020
width: 16px;
2121
flex-shrink: 0;
@@ -112,7 +112,7 @@
112112
.tableWrap {
113113
margin-top: 16px;
114114
min-height: 360px;
115-
min-width: 648px;
115+
min-width: 748px;
116116
border: 1px solid var(--table-head-border-color);
117117
border-radius: 16px;
118118
border-top: none;
@@ -130,18 +130,58 @@
130130
.address {
131131
font-family: 'JetBrains Mono';
132132
position: relative;
133+
display: flex;
134+
align-items: center;
135+
column-gap: 4px;
133136

134-
.legacy {
135-
font-size: 10px;
136-
height: 16px;
137-
color: var(--third-text-color);
137+
.titleWrap {
138+
display: flex;
139+
align-items: center;
140+
column-gap: 4px;
141+
color: var(--main-text-color);
138142
font-weight: 500;
139-
position: absolute;
140-
top: -16px;
141-
right: -10px;
142-
background: var(--table-head-border-color);
143+
144+
.tag {
145+
font-size: 12px;
146+
line-height: 18px;
147+
color: var(--tabs-active);
148+
font-weight: 500;
149+
background: var(--tag-background-color);
150+
padding: 0 4px;
151+
border-radius: 2px;
152+
}
153+
.legacy {
154+
color: var(--third-text-color);
155+
background: var(--input-border-color);
156+
}
157+
}
158+
.lockCodeHash {
159+
display: flex;
160+
align-items: center;
161+
font-size: 13px;
162+
border: 1px solid var(--tabs-active);
163+
border-radius: 4px;
143164
padding: 0 4px;
144-
border-radius: 48px;
165+
line-height: 24px;
166+
color: var(--tabs-active);
167+
font-weight: 500;
168+
&.legacy {
169+
border: 1px solid var(--divide-line-color);
170+
color: var(--input-second-color);
171+
svg {
172+
path {
173+
stroke: var(--input-second-color);
174+
}
175+
}
176+
}
177+
}
178+
179+
.copyLockCodeHash {
180+
@include copyAddress;
181+
}
182+
183+
.lockCodeHashTip {
184+
margin-left: 50px;
145185
}
146186
}
147187

‎packages/neuron-ui/src/utils/enums.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,15 @@ export enum LegacyMultiSigLockInfo {
155155
HashType = 'type',
156156
CodeHashIndex = '0x01',
157157
ArgsLen = '20',
158-
TagName = 'secp256k1/multisig/legacy',
158+
TagName = 'secp256k1/multisig/@5c5069eb',
159159
}
160160

161161
export enum MultiSigLockInfo {
162162
CodeHash = '0x36c971b8d41fbd94aabca77dc75e826729ac98447b46f91e00796155dddb0d29',
163163
HashType = 'data1',
164164
CodeHashIndex = '0x01',
165165
ArgsLen = '20',
166-
TagName = 'secp256k1/multisig',
166+
TagName = 'secp256k1/multisig/@36c971b8',
167167
}
168168

169169
export enum LocktimeLockInfo {

‎packages/neuron-ui/src/widgets/Icons/LockCodeHash.svg‎

Lines changed: 11 additions & 0 deletions
Loading

‎packages/neuron-ui/src/widgets/Icons/icon.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ import DAOWithdrawalSvg from './DAOWithdrawal.svg?react'
6868
import RecycleSvg from './Recycle.svg?react'
6969
import MoreSvg from './More.svg?react'
7070
import RegenerateSvg from './Regenerate.svg?react'
71+
import LockCodeHashSvg from './LockCodeHash.svg?react'
7172

7273
import styles from './icon.module.scss'
7374

@@ -152,3 +153,4 @@ export const DAOWithdrawal = WrapSvg(DAOWithdrawalSvg)
152153
export const Recycle = WrapSvg(RecycleSvg)
153154
export const More = WrapSvg(MoreSvg)
154155
export const Regenerate = WrapSvg(RegenerateSvg)
156+
export const LockCodeHash = WrapSvg(LockCodeHashSvg)

‎packages/neuron-wallet/src/block-sync-renderer/sync/light-synchronizer.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import Multisig from '../../services/multisig'
1212
import SyncProgress, { SyncAddressType } from '../../database/chain/entities/sync-progress'
1313
import WalletService from '../../services/wallets'
1414
import AssetAccountInfo from '../../models/asset-account-info'
15+
import SystemScriptInfo from '../../models/system-script-info'
1516
import { DepType } from '../../models/chain/cell-dep'
1617
import { vector, blockchain } from '@ckb-lumos/lumos/codec'
1718
import type { Base } from '@ckb-lumos/lumos/rpc'
@@ -39,6 +40,9 @@ export default class LightSynchronizer extends Synchronizer {
3940

4041
private async getDepTxs(): Promise<string[]> {
4142
const assetAccountInfo = new AssetAccountInfo()
43+
const multiSignCellDep = await SystemScriptInfo.getInstance().getMultiSignCellDep(
44+
SystemScriptInfo.MULTISIG_CODE_HASH
45+
)
4246
const fetchCellDeps = [
4347
assetAccountInfo.anyoneCanPayCellDep,
4448
assetAccountInfo.sudtCellDep,
@@ -48,6 +52,8 @@ export default class LightSynchronizer extends Synchronizer {
4852
assetAccountInfo.getNftIssuerInfo().cellDep,
4953
assetAccountInfo.getLegacyAnyoneCanPayInfo().cellDep,
5054
assetAccountInfo.getChequeInfo().cellDep,
55+
multiSignCellDep,
56+
5157
...assetAccountInfo.getSporeInfos().map(info => info.cellDep),
5258
...assetAccountInfo.getSporeClusterInfo().map(info => info.cellDep),
5359
]

‎packages/neuron-wallet/src/controllers/multisig.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ interface MultisigConfigItem {
2424
sighash_addresses: string[]
2525
require_first_n: number
2626
threshold: number
27-
alias?: string | string[]
28-
lockCodeHash: string | string[]
27+
alias?: string
28+
lockCodeHash: string
2929
}
3030

3131
interface MultisigConfigOutput {
3232
multisig_configs: Record<string, MultisigConfigItem>
3333
}
3434

3535
interface MultisigConfigInput {
36-
multisig_configs: Record<string, Omit<MultisigConfigItem, 'lockCodeHash'> & { lockCodeHash?: string | string[] }>
36+
multisig_configs: Record<string, Omit<MultisigConfigItem, 'lockCodeHash'> & { lockCodeHash?: string }>
3737
}
3838

3939
const validateImportConfig = (configOutput: MultisigConfigInput) => {

‎packages/neuron-wallet/src/models/system-script-info.ts‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ export default class SystemScriptInfo {
1515

1616
static SECP_HASH_TYPE = ScriptHashType.Type
1717
static DAO_HASH_TYPE = ScriptHashType.Type
18-
static LEGACY_MULTI_SIGN_HASH_TYPE = ScriptHashType.Type
19-
static MULTI_SIGN_HASH_TYPE = ScriptHashType.Data1
18+
static LEGACY_MULTISIGN_HASH_TYPE = ScriptHashType.Type
19+
static MULTISIGN_HASH_TYPE = ScriptHashType.Data1
2020

2121
static DAO_SCRIPT_HASH = new Script(
2222
systemScripts.DAO.CODE_HASH,
@@ -41,11 +41,12 @@ export default class SystemScriptInfo {
4141
private legacyMultiSignOutPointInfo = new Map<string, OutPoint>()
4242
private multiSignOutPointInfo = new Map<string, OutPoint>()
4343

44-
public static getMultiSignHashType(lockCodeHash: string): ScriptHashType {
45-
if (lockCodeHash === SystemScriptInfo.MULTISIG_CODE_HASH) {
46-
return SystemScriptInfo.MULTI_SIGN_HASH_TYPE
44+
public static getMultiSignHashType(lockCodeHash: string) {
45+
if (!SystemScriptInfo.isMultiSignCodeHash(lockCodeHash)) {
46+
throw new Error('Unknown Multisig Code Hash')
4747
}
48-
return SystemScriptInfo.LEGACY_MULTI_SIGN_HASH_TYPE
48+
if (lockCodeHash === SystemScriptInfo.MULTISIG_CODE_HASH) return SystemScriptInfo.MULTISIGN_HASH_TYPE
49+
if (lockCodeHash === SystemScriptInfo.LEGACY_MULTISIG_CODE_HASH) return SystemScriptInfo.LEGACY_MULTISIGN_HASH_TYPE
4950
}
5051

5152
// need network url and genesisBlockHash
@@ -119,9 +120,9 @@ export default class SystemScriptInfo {
119120
public static isMultiSignScript(script: Script): boolean {
120121
return (
121122
(script.codeHash === SystemScriptInfo.LEGACY_MULTISIG_CODE_HASH &&
122-
script.hashType === SystemScriptInfo.LEGACY_MULTI_SIGN_HASH_TYPE) ||
123+
script.hashType === SystemScriptInfo.LEGACY_MULTISIGN_HASH_TYPE) ||
123124
(script.codeHash === SystemScriptInfo.MULTISIG_CODE_HASH &&
124-
script.hashType === SystemScriptInfo.MULTI_SIGN_HASH_TYPE)
125+
script.hashType === SystemScriptInfo.MULTISIGN_HASH_TYPE)
125126
)
126127
}
127128

‎packages/neuron-wallet/src/services/hardware/hardware.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export abstract class Hardware {
4343
})
4444

4545
const isMultisig =
46-
tx.inputs.length === 1 && tx.inputs[0].lock!.args.length === TransactionSender.MULTI_SIGN_ARGS_LENGTH
46+
tx.inputs.length === 1 && tx.inputs[0].lock!.args.length === TransactionSender.MULTISIGN_ARGS_LENGTH
4747

4848
const multiSignBlake160s = isMultisig
4949
? addressInfos.map(i => {
@@ -55,7 +55,7 @@ export abstract class Hardware {
5555
: []
5656

5757
const findPath = (args: string) => {
58-
if (args.length === TransactionSender.MULTI_SIGN_ARGS_LENGTH) {
58+
if (args.length === TransactionSender.MULTISIGN_ARGS_LENGTH) {
5959
return multiSignBlake160s.find(i => args.slice(0, 42) === i.multiSignBlake160)!.path
6060
} else if (args.length === 42) {
6161
return addressInfos.find(i => i.blake160 === args)!.path

0 commit comments

Comments
 (0)