Replace a few unnecessary preg_match calls

Author: theodorejb

src/ParserAbstract.php

@@ -513,7 +513,7 @@ protected function locInfo(int $tokenStartPos, int $tokenEndPos): SourceLocation
 
     protected function id(string $token): string
     {
-        if (preg_match('/^\\[.*]$/', $token)) {
+        if ($token !== '' && $token[0] === '[' && $token[-1] === ']') {
             return substr($token, 1, -1);
         } else {
             return $token;
@@ -562,7 +562,7 @@ protected function prepareMustache(
     ): MustacheStatement {
         $escapeFlag = $open[3] ?? $open[2] ?? '';
         $escaped = $escapeFlag !== '{' && $escapeFlag !== '&';
-        $decorator = preg_match('/\\*/', $open);
+        $decorator = str_contains($open, '*');
 
         return new MustacheStatement(
             type: $decorator ? 'Decorator' : 'MustacheStatement',
@@ -613,7 +613,7 @@ protected function preparePath(bool $data, ?SubExpression $sexpr, array $parts,
             $original .= ($separator ?? '') . $part;
 
             if (!$isLiteral && ($part === '..' || $part === '.' || $part === 'this')) {
-                if (count($tail) > 0) {
+                if ($tail !== []) {
                     $msg = $this->getNodeError("Invalid path: $original", new Node('', $loc));
                     throw new \Exception($msg);
                 } elseif ($part === '..') {
@@ -673,7 +673,7 @@ protected function prepareBlock(
             $this->validateClose($openBlock, $close);
         }
 
-        $decorator = preg_match('/\\*/', $openBlock->open);
+        $decorator = str_contains($openBlock->open, '*');
 
         $program->blockParams = $openBlock->blockParams;
 

src/WhitespaceControl.php

@@ -134,11 +134,12 @@ private function visitBlock(BlockStatement|PartialBlockStatement $block): StripI
         }
 
         // Find the inverse program that is involved with whitespace stripping.
-        $program = $block instanceof BlockStatement
+        $isBlockStatement = $block instanceof BlockStatement;
+        $program = $isBlockStatement
             ? ($block->program ?? $block->inverse)
             : $block->program;
 
-        $inverse = ($block instanceof BlockStatement && $block->program && $block->inverse)
+        $inverse = ($isBlockStatement && $block->program && $block->inverse)
             ? $block->inverse
             : null;
         $firstInverse = $inverse;

tests/ParserTest.php

@@ -2,7 +2,6 @@
 
 namespace DevTheorem\HandlebarsParser\Test;
 
-use DevTheorem\HandlebarsParser\Ast\Program;
 use DevTheorem\HandlebarsParser\ParserFactory;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
@@ -296,8 +295,8 @@ public function testSpecs(array $spec): void
         $parser = (new ParserFactory())->create();
 
         try {
-            $result = $parser->parse($spec['template']);
-            $this->assertInstanceOf(Program::class, $result);
+            $parser->parse($spec['template']);
+            $this->expectNotToPerformAssertions();
         } catch (\Exception $e) {
             if (isset($spec['exception'])) {
                 if (is_string($spec['exception'])) {