"java.class.path" uses an incorrect separator #107

Author: andrus

RELEASE-NOTES.md

@@ -3,6 +3,7 @@
 * #67 JJAVA_STARTUP_SCRIPT can't start up spark
 * #102 Eval startup snippets explicitly
 * #105 Exploding classpath
+* #107 "java.class.path" uses an incorrect separator
 
 ## 1.0-a6
 

jjava-kernel/src/main/java/org/dflib/jjava/kernel/execution/JJavaLoaderDelegate.java

@@ -15,6 +15,7 @@
 public class JJavaLoaderDelegate implements LoaderDelegate {
 
     private static final String CLASSPATH_PROPERTY = "java.class.path";
+    private static final String PATH_SEPARATOR = System.getProperty("path.separator");
 
     private final Map<String, byte[]> declaredClasses;
     private final Map<String, Class<?>> loadedClasses;
@@ -57,9 +58,10 @@ public void addToClasspath(String path) throws ExecutionControl.InternalExceptio
             try {
                 classLoader.addURL(Path.of(next).toUri().toURL());
 
-                String classpath = System.getProperty(CLASSPATH_PROPERTY);
-                classpath += System.lineSeparator() + next;
-                System.setProperty(CLASSPATH_PROPERTY, classpath);
+                System.setProperty(
+                        CLASSPATH_PROPERTY,
+                        System.getProperty(CLASSPATH_PROPERTY) + PATH_SEPARATOR + next);
+
             } catch (MalformedURLException e) {
                 throw new ExecutionControl.InternalException("Unable to resolve classpath " + next
                         + ": " + e.getMessage());

jjava-kernel/src/test/java/org/dflib/jjava/kernel/JJavaLoaderDelegateTest.java

@@ -0,0 +1,29 @@
+package org.dflib.jjava.kernel;
+
+import jdk.jshell.spi.ExecutionControl;
+import org.dflib.jjava.kernel.execution.JJavaLoaderDelegate;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.net.URISyntaxException;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class JJavaLoaderDelegateTest {
+
+    @Test
+    public void addToClasspath() throws URISyntaxException, ExecutionControl.InternalException {
+        File extraCp = new File(getClass().getResource("cp").toURI());
+        assertTrue(extraCp.isDirectory());
+
+        JJavaLoaderDelegate ld = new JJavaLoaderDelegate();
+
+        String cp1 = System.getProperty("java.class.path");
+
+        ld.addToClasspath(extraCp.getAbsolutePath());
+        String cp2 = System.getProperty("java.class.path");
+        assertEquals(cp1 + System.getProperty("path.separator") + extraCp.getAbsolutePath(), cp2);
+
+        // TODO: test that classes from this location were actually loaded
+    }
+}

jjava-kernel/src/test/resources/org/dflib/jjava/kernel/cp/.gitignore

@@ -0,0 +1 @@
+# placeholder to keep the empty directory in version control