From bdec90b1160460a4b214c7ec0173fb0bae0c2f77 Mon Sep 17 00:00:00 2001 From: Dipanshu Singh Date: Wed, 27 May 2026 16:23:39 +0530 Subject: [PATCH] NavMarkGutterRenderer: fix crash when deleting edit marks (#1681) Deleting an edit mark emitted the mark-deleted signal from the GtkTextBuffer. However, the signal handler in SourceView.vala called emove_mark(), which attempted to delete the mark from the buffer a second time. This double-delete caused invalid memory access and an occasional segmentation fault. This commit removes the redundant delete_mark call from emove_mark(). --- src/Widgets/NavMarkGutterRenderer.vala | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Widgets/NavMarkGutterRenderer.vala b/src/Widgets/NavMarkGutterRenderer.vala index 369ffbd2e0..501a471929 100644 --- a/src/Widgets/NavMarkGutterRenderer.vala +++ b/src/Widgets/NavMarkGutterRenderer.vala @@ -33,7 +33,6 @@ public class Scratch.Widgets.NavMarkGutterRenderer : Gtk.SourceGutterRendererPix } public void remove_mark (Gtk.TextMark mark) { - buffer.delete_mark (mark); mark_list.remove (mark); purge_and_sort_mark_list (); }